diff mbox

arm64: Fix compilation error with EARLY_PRINTK disabled

Message ID 1366915189-20509-1-git-send-email-julien.grall@linaro.org
State Accepted, archived
Headers show

Commit Message

Julien Grall April 25, 2013, 6:39 p.m. UTC 
arm64/head.S: Assembler messages:
arm64/head.S:391: Error: operand 1 should be an integer register -- `mov pc,lr'

Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
 xen/arch/arm/arm64/head.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ian Campbell April 26, 2013, 8:50 a.m. UTC | #1 
On Thu, 2013-04-25 at 19:39 +0100, Julien Grall wrote:
> arm64/head.S: Assembler messages:
> arm64/head.S:391: Error: operand 1 should be an integer register -- `mov pc,lr'
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> ---
>  xen/arch/arm/arm64/head.S |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index f0d9066..ef02899 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -388,6 +388,6 @@ init_uart:
>  .global early_puts
>  early_puts:
>  puts:
> -putn:   mov   pc, lr
> +putn:   ret
>  
>  #endif /* EARLY_UART_ADDRESS */
Ian Campbell April 26, 2013, 3:34 p.m. UTC | #2 
On Fri, 2013-04-26 at 09:50 +0100, Ian Campbell wrote:
> On Thu, 2013-04-25 at 19:39 +0100, Julien Grall wrote:
> > arm64/head.S: Assembler messages:
> > arm64/head.S:391: Error: operand 1 should be an integer register -- `mov pc,lr'
> > 
> > Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Applied, thanks.
diff mbox

Patch

diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index f0d9066..ef02899 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -388,6 +388,6 @@  init_uart:
 .global early_puts
 early_puts:
 puts:
-putn:   mov   pc, lr
+putn:   ret
 
 #endif /* EARLY_UART_ADDRESS */