| Message ID | 1557666733-19527-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 029f162ab09d254e03050908c8554f6328d3908a |
| Headers | show |
| Series | nios2: remove pointless second entry for CONFIG_TRACE_IRQFLAGS_SUPPORT | expand |
On Sun, May 12, 2019 at 10:16 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > Strangely enough, NIOS2 defines TRACE_IRQFLAGS_SUPPORT twice > with different values, which is pointless and confusing. > > [1] arch/nios2/Kconfig > > config TRACE_IRQFLAGS_SUPPORT > def_bool n > > [2] arch/nios2/Kconfig.debug > > config TRACE_IRQFLAGS_SUPPORT > def_bool y > > [1] is included before [2]. In the Kconfig syntax, the first one > is effective. So, TRACE_IRQFLAGS_SUPPORT is always 'n'. > > The second define in arch/nios2/Kconfig.debug is dead code. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- Ping. > arch/nios2/Kconfig.debug | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug > index f1da8a7..a8bc06e 100644 > --- a/arch/nios2/Kconfig.debug > +++ b/arch/nios2/Kconfig.debug > @@ -1,8 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > > -config TRACE_IRQFLAGS_SUPPORT > - def_bool y > - > config EARLY_PRINTK > bool "Activate early kernel debugging" > default y > -- > 2.7.4 > -- Best Regards Masahiro Yamada
On Sun, 2019-06-23 at 23:13 +0900, Masahiro Yamada wrote: > On Sun, May 12, 2019 at 10:16 PM Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: > > > > > > Strangely enough, NIOS2 defines TRACE_IRQFLAGS_SUPPORT twice > > with different values, which is pointless and confusing. > > > > [1] arch/nios2/Kconfig > > > > config TRACE_IRQFLAGS_SUPPORT > > def_bool n > > > > [2] arch/nios2/Kconfig.debug > > > > config TRACE_IRQFLAGS_SUPPORT > > def_bool y > > > > [1] is included before [2]. In the Kconfig syntax, the first one > > is effective. So, TRACE_IRQFLAGS_SUPPORT is always 'n'. > > > > The second define in arch/nios2/Kconfig.debug is dead code. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > Ping. > > Acked-by: Ley Foon Tan <ley.foon.tan@intel.com> Will integrate to next kernel version. Thanks. > > > > arch/nios2/Kconfig.debug | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug > > index f1da8a7..a8bc06e 100644 > > --- a/arch/nios2/Kconfig.debug > > +++ b/arch/nios2/Kconfig.debug > > @@ -1,8 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0 > > > > -config TRACE_IRQFLAGS_SUPPORT > > - def_bool y > > - > > config EARLY_PRINTK > > bool "Activate early kernel debugging" > > default y > > -- > > 2.7.4 > > > > -- > Best Regards > Masahiro Yamada > > ________________________________ Regards Ley Foon
diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug index f1da8a7..a8bc06e 100644 --- a/arch/nios2/Kconfig.debug +++ b/arch/nios2/Kconfig.debug @@ -1,8 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -config TRACE_IRQFLAGS_SUPPORT - def_bool y - config EARLY_PRINTK bool "Activate early kernel debugging" default y
Strangely enough, NIOS2 defines TRACE_IRQFLAGS_SUPPORT twice with different values, which is pointless and confusing. [1] arch/nios2/Kconfig config TRACE_IRQFLAGS_SUPPORT def_bool n [2] arch/nios2/Kconfig.debug config TRACE_IRQFLAGS_SUPPORT def_bool y [1] is included before [2]. In the Kconfig syntax, the first one is effective. So, TRACE_IRQFLAGS_SUPPORT is always 'n'. The second define in arch/nios2/Kconfig.debug is dead code. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- arch/nios2/Kconfig.debug | 3 --- 1 file changed, 3 deletions(-) -- 2.7.4