| Message ID | 1553921453-23777-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Remove SPDX "WITH Linux-syscall-note" from kernel-space headers | expand |
On Sat, Mar 30, 2019 at 1:54 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > The "WITH Linux-syscall-note" should be added to headers exported to > the user-space. > > Some kernel-space headers have "WITH Linux-syscall-note", which seems > a mistake. > > [1] arch/x86/include/asm/hyperv-tlfs.h > > 5a4858032217 ("x86/hyper-v: move hyperv.h out of uapi") moved this file > out of uapi, but missed to update the SPDX License tag. > > [2] include/asm-generic/shmparam.h > > 76ce2a80a28e ("Rename include/{uapi => }/asm-generic/shmparam.h really") > moved this file out of uapi, but missed to update the SPDX License tag. > > [3] include/linux/qcom-geni-se.h > > eddac5af0654 ("soc: qcom: Add GENI based QUP Wrapper driver") added this > file, but I do now see a good reason why its license tag must include This is a fatal typo, which makes the meaning opposite. "I do now see ..." -> "I do not see ..." > "WITH Linux-syscall-note". > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > arch/x86/include/asm/hyperv-tlfs.h | 2 +- > include/asm-generic/shmparam.h | 2 +- > include/linux/qcom-geni-se.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h > index 2bdbbbc..cdf44aa 100644 > --- a/arch/x86/include/asm/hyperv-tlfs.h > +++ b/arch/x86/include/asm/hyperv-tlfs.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > +/* SPDX-License-Identifier: GPL-2.0 */ > > /* > * This file contains definitions from Hyper-V Hypervisor Top-Level Functional > diff --git a/include/asm-generic/shmparam.h b/include/asm-generic/shmparam.h > index 8b78c0b..b8f9035 100644 > --- a/include/asm-generic/shmparam.h > +++ b/include/asm-generic/shmparam.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > +/* SPDX-License-Identifier: GPL-2.0 */ > #ifndef __ASM_GENERIC_SHMPARAM_H > #define __ASM_GENERIC_SHMPARAM_H > > diff --git a/include/linux/qcom-geni-se.h b/include/linux/qcom-geni-se.h > index 3bcd67f..dd46494 100644 > --- a/include/linux/qcom-geni-se.h > +++ b/include/linux/qcom-geni-se.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > +/* SPDX-License-Identifier: GPL-2.0 */ > /* > * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. > */ > -- > 2.7.4 > -- Best Regards Masahiro Yamada
diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h index 2bdbbbc..cdf44aa 100644 --- a/arch/x86/include/asm/hyperv-tlfs.h +++ b/arch/x86/include/asm/hyperv-tlfs.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* SPDX-License-Identifier: GPL-2.0 */ /* * This file contains definitions from Hyper-V Hypervisor Top-Level Functional diff --git a/include/asm-generic/shmparam.h b/include/asm-generic/shmparam.h index 8b78c0b..b8f9035 100644 --- a/include/asm-generic/shmparam.h +++ b/include/asm-generic/shmparam.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* SPDX-License-Identifier: GPL-2.0 */ #ifndef __ASM_GENERIC_SHMPARAM_H #define __ASM_GENERIC_SHMPARAM_H diff --git a/include/linux/qcom-geni-se.h b/include/linux/qcom-geni-se.h index 3bcd67f..dd46494 100644 --- a/include/linux/qcom-geni-se.h +++ b/include/linux/qcom-geni-se.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. */
The "WITH Linux-syscall-note" should be added to headers exported to the user-space. Some kernel-space headers have "WITH Linux-syscall-note", which seems a mistake. [1] arch/x86/include/asm/hyperv-tlfs.h 5a4858032217 ("x86/hyper-v: move hyperv.h out of uapi") moved this file out of uapi, but missed to update the SPDX License tag. [2] include/asm-generic/shmparam.h 76ce2a80a28e ("Rename include/{uapi => }/asm-generic/shmparam.h really") moved this file out of uapi, but missed to update the SPDX License tag. [3] include/linux/qcom-geni-se.h eddac5af0654 ("soc: qcom: Add GENI based QUP Wrapper driver") added this file, but I do now see a good reason why its license tag must include "WITH Linux-syscall-note". Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- arch/x86/include/asm/hyperv-tlfs.h | 2 +- include/asm-generic/shmparam.h | 2 +- include/linux/qcom-geni-se.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- 2.7.4