diff mbox series

[v3,1/2] dt-bindings: arm: coresight: Support static funnel

Message ID 20190328023509.22242-2-leo.yan@linaro.org
State New
Headers show
Series CoreSight: Support static funnel | expand

Commit Message

Leo Yan March 28, 2019, 2:35 a.m. UTC 
Document DT binding for static (non-configurable) funnel and give an
example for it.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Wanglai Shi <shiwanglai@hisilicon.com>
Signed-off-by: Leo Yan <leo.yan@linaro.org>

---
 .../devicetree/bindings/arm/coresight.txt     | 45 +++++++++++++++++--
 1 file changed, 42 insertions(+), 3 deletions(-)

-- 
2.17.1

Comments

Rob Herring March 28, 2019, 7:06 p.m. UTC | #1 
On Thu, 28 Mar 2019 10:35:08 +0800, Leo Yan wrote:
> Document DT binding for static (non-configurable) funnel and give an

> example for it.

> 

> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>

> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>

> Cc: Wanglai Shi <shiwanglai@hisilicon.com>

> Signed-off-by: Leo Yan <leo.yan@linaro.org>

> ---

>  .../devicetree/bindings/arm/coresight.txt     | 45 +++++++++++++++++--

>  1 file changed, 42 insertions(+), 3 deletions(-)

> 


Reviewed-by: Rob Herring <robh@kernel.org>
Leo Yan March 29, 2019, 12:21 a.m. UTC | #2 
On Thu, Mar 28, 2019 at 07:24:35PM +0000, Suzuki K Poulose wrote:
> On 03/28/2019 02:35 AM, Leo Yan wrote:

> > Document DT binding for static (non-configurable) funnel and give an

> > example for it.

> > 

> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>

> > Cc: Suzuki K Poulose <suzuki.poulose@arm.com>

> > Cc: Wanglai Shi <shiwanglai@hisilicon.com>

> > Signed-off-by: Leo Yan <leo.yan@linaro.org>

> 

> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>


Thanks for reviewing, Rob & Suzuki.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
index f8aff65ab921..42935c6ca9d6 100644
--- a/Documentation/devicetree/bindings/arm/coresight.txt
+++ b/Documentation/devicetree/bindings/arm/coresight.txt
@@ -8,7 +8,8 @@  through the intermediate links connecting the source to the currently selected
 sink. Each CoreSight component device should use these properties to describe
 its hardware characteristcs.
 
-* Required properties for all components *except* non-configurable replicators:
+* Required properties for all components *except* non-configurable replicators
+  and non-configurable funnels:
 
 	* compatible: These have to be supplemented with "arm,primecell" as
 	  drivers are using the AMBA bus interface.  Possible values include:
@@ -24,7 +25,7 @@  its hardware characteristcs.
 		  discovered at boot time when the device is probed.
 			"arm,coresight-tmc", "arm,primecell";
 
-		- Trace Funnel:
+		- Trace Programmable Funnel:
 			"arm,coresight-funnel", "arm,primecell";
 
 		- Embedded Trace Macrocell (version 3.x) and
@@ -65,11 +66,12 @@  its hardware characteristcs.
 	  "stm-stimulus-base", each corresponding to the areas defined in "reg".
 
 * Required properties for devices that don't show up on the AMBA bus, such as
-  non-configurable replicators:
+  non-configurable replicators and non-configurable funnels:
 
 	* compatible: Currently supported value is (note the absence of the
 	  AMBA markee):
 		- "arm,coresight-replicator"
+		- "arm,coresight-static-funnel"
 
 	* port or ports: see "Graph bindings for Coresight" below.
 
@@ -200,6 +202,43 @@  Example:
 		};
 	};
 
+	funnel {
+		/*
+		 * non-configurable funnel don't show up on the AMBA
+		 * bus.  As such no need to add "arm,primecell".
+		 */
+		compatible = "arm,coresight-static-funnel";
+		clocks = <&crg_ctrl HI3660_PCLK>;
+		clock-names = "apb_pclk";
+
+		out-ports {
+			port {
+				combo_funnel_out: endpoint {
+					remote-endpoint = <&top_funnel_in>;
+				};
+			};
+		};
+
+		in-ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				combo_funnel_in0: endpoint {
+					remote-endpoint = <&cluster0_etf_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				combo_funnel_in1: endpoint {
+					remote-endpoint = <&cluster1_etf_out>;
+				};
+			};
+		};
+	};
+
 	funnel@20040000 {
 		compatible = "arm,coresight-funnel", "arm,primecell";
 		reg = <0 0x20040000 0 0x1000>;