| Message ID | 20190311095613.11371-5-narmstrong@baylibre.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | None | expand |
Hi Neil, On Mon, Mar 11, 2019 at 10:57 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > From: Jerome Brunet <jbrunet@baylibre.com> > > Add system regulators for the S905D2 U200 reference design. I find the hint in the meson-g12a-sei510 regulators patch very good: Still missing * VDD_EE (0.8V - PWM controlled) * VDD_CPU(PWM controlled) * VDDQ1_5 VDD_EE and VDD_CPU are *probably* going to be very similar across all boards (Meson8b uses two slightly different PWM regulators on all boards supported by mainline, but the basic concept is always the same) I'm not sure if VDDQ1_5 is specific to the SEI510 board though. > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > .../boot/dts/amlogic/meson-g12a-u200.dts | 79 +++++++++++++++++++ > 1 file changed, 79 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts > index f2afd0bf3e28..17696f356ff2 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts > @@ -14,13 +14,92 @@ > aliases { > serial0 = &uart_AO; > }; > + > chosen { > stdout-path = "serial0:115200n8"; > }; > + > memory@0 { > device_type = "memory"; > reg = <0x0 0x0 0x0 0x40000000>; > }; there are two unrelated whitespace changes above. please clean them up if you have to re-send this for whatever reason Regards Martin
HI, Le 15/03/2019 23:01, Martin Blumenstingl a écrit : > Hi Neil, > > On Mon, Mar 11, 2019 at 10:57 AM Neil Armstrong <narmstrong@baylibre.com> wrote: >> >> From: Jerome Brunet <jbrunet@baylibre.com> >> >> Add system regulators for the S905D2 U200 reference design. > I find the hint in the meson-g12a-sei510 regulators patch very good: > Still missing > * VDD_EE (0.8V - PWM controlled) > * VDD_CPU(PWM controlled) > * VDDQ1_5 I will add the same comment here > > VDD_EE and VDD_CPU are *probably* going to be very similar across all > boards (Meson8b uses two slightly different PWM regulators on all > boards supported by mainline, but the basic concept is always the > same) Not necessarily, it can change, it used to change across GXBB boards, but seems to be more coherent across GXL/GXM/G12A ref designs and derivative boards, but it can still change if the HW designer decides to be creative ! > I'm not sure if VDDQ1_5 is specific to the SEI510 board though. I think VDDQ1_5 is specific to SEI510, will check on the schematics > >> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> --- >> .../boot/dts/amlogic/meson-g12a-u200.dts | 79 +++++++++++++++++++ >> 1 file changed, 79 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts >> index f2afd0bf3e28..17696f356ff2 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts >> @@ -14,13 +14,92 @@ >> aliases { >> serial0 = &uart_AO; >> }; >> + >> chosen { >> stdout-path = "serial0:115200n8"; >> }; >> + >> memory@0 { >> device_type = "memory"; >> reg = <0x0 0x0 0x0 0x40000000>; >> }; > there are two unrelated whitespace changes above. > please clean them up if you have to re-send this for whatever reason Yep, will cleanup > > > Regards > Martin >
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts index f2afd0bf3e28..17696f356ff2 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts @@ -14,13 +14,92 @@ aliases { serial0 = &uart_AO; }; + chosen { stdout-path = "serial0:115200n8"; }; + memory@0 { device_type = "memory"; reg = <0x0 0x0 0x0 0x40000000>; }; + + flash_1v8: regulator-flash_1v8 { + compatible = "regulator-fixed"; + regulator-name = "FLASH_1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + vin-supply = <&vcc_3v3>; + regulator-always-on; + }; + + main_12v: regulator-main_12v { + compatible = "regulator-fixed"; + regulator-name = "12V"; + regulator-min-microvolt = <12000000>; + regulator-max-microvolt = <12000000>; + regulator-always-on; + }; + + vcc_1v8: regulator-vcc_1v8 { + compatible = "regulator-fixed"; + regulator-name = "VCC_1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + vin-supply = <&vcc_3v3>; + regulator-always-on; + }; + + vcc_3v3: regulator-vcc_3v3 { + compatible = "regulator-fixed"; + regulator-name = "VCC_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + vin-supply = <&vddao_3v3>; + regulator-always-on; + /* FIXME: actually controlled by VDDCPU_B_EN */ + }; + + vcc_5v: regulator-vcc_5v { + compatible = "regulator-fixed"; + regulator-name = "VCC_5V"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + vin-supply = <&main_12v>; + + gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>; + enable-active-high; + }; + + usb_pwr_en: regulator-usb_pwr_en { + compatible = "regulator-fixed"; + regulator-name = "USB_PWR_EN"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + vin-supply = <&vcc_5v>; + + gpio = <&gpio GPIOH_6 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + + vddao_1v8: regulator-vddao_1v8 { + compatible = "regulator-fixed"; + regulator-name = "VDDAO_1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + vin-supply = <&vddao_3v3>; + regulator-always-on; + }; + + vddao_3v3: regulator-vddao_3v3 { + compatible = "regulator-fixed"; + regulator-name = "VDDAO_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + vin-supply = <&main_12v>; + regulator-always-on; + }; + }; &uart_AO {