| Message ID | 20190222185026.10973-9-will.deacon@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Remove Mysterious Macro Intended to Obscure Weird Behaviours (mmiowb()) | expand |
Hi Will, On Fri, Feb 22, 2019 at 7:51 PM Will Deacon <will.deacon@arm.com> wrote: > m68k includes asm-generic/io.h, which provides a dummy definition of > mmiowb() if one isn't already provided by the architecture. > > Remove the useless definition. > > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Will Deacon <will.deacon@arm.com> Thanks! Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Do you want me to queue this in the m68k tree for v5.2, or would you prefer to apply the whole series? In case of the latter: Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Feb 25, 2019 at 10:25:52AM +0100, Geert Uytterhoeven wrote: > On Fri, Feb 22, 2019 at 7:51 PM Will Deacon <will.deacon@arm.com> wrote: > > m68k includes asm-generic/io.h, which provides a dummy definition of > > mmiowb() if one isn't already provided by the architecture. > > > > Remove the useless definition. > > > > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > > Signed-off-by: Will Deacon <will.deacon@arm.com> > > Thanks! > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Do you want me to queue this in the m68k tree for v5.2, or would > you prefer to apply the whole series? > In case of the latter: > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Cheers, Geert! For now, I think it's best to keep all the patches together since I anticipate a few rounds of rework before I have a good idea about what the final series will look like. Will
diff --git a/arch/m68k/include/asm/io_mm.h b/arch/m68k/include/asm/io_mm.h index 782b78f8a048..6c03ca5bc436 100644 --- a/arch/m68k/include/asm/io_mm.h +++ b/arch/m68k/include/asm/io_mm.h @@ -377,8 +377,6 @@ static inline void isa_delay(void) #define writesw(port, buf, nr) raw_outsw((port), (u16 *)(buf), (nr)) #define writesl(port, buf, nr) raw_outsl((port), (u32 *)(buf), (nr)) -#define mmiowb() - #ifndef CONFIG_SUN3 #define IO_SPACE_LIMIT 0xffff #else
m68k includes asm-generic/io.h, which provides a dummy definition of mmiowb() if one isn't already provided by the architecture. Remove the useless definition. Cc: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Will Deacon <will.deacon@arm.com> --- arch/m68k/include/asm/io_mm.h | 2 -- 1 file changed, 2 deletions(-) -- 2.11.0