| Message ID | 20190205200512.11572-1-linus.walleij@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/6] mmc: mxcmmc: Drop unused includes | expand |
On Tue, 5 Feb 2019 at 21:07, Linus Walleij <linus.walleij@linaro.org> wrote: > > The MXCMMC driver uses slot GPIO helpers and does not make > any use of <linux/gpio.h> or <linux/of_gpio.h> so drop these > surplus includes. As already pointed out by reviewers, looks like you cut and pasted the above same changelog for each of the patch in the series. :-) Please take a round to update them all for they become correct, then I can apply them. Kind regards Uffe > > Cc: Jun Qian <hangdianqj@163.com> > Cc: Matteo Facchinetti <matteo.facchinetti@sirius-es.it> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/mmc/host/mxcmmc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c > index 4d17032d15ee..d54612257b06 100644 > --- a/drivers/mmc/host/mxcmmc.c > +++ b/drivers/mmc/host/mxcmmc.c > @@ -31,14 +31,12 @@ > #include <linux/delay.h> > #include <linux/clk.h> > #include <linux/io.h> > -#include <linux/gpio.h> > #include <linux/regulator/consumer.h> > #include <linux/dmaengine.h> > #include <linux/types.h> > #include <linux/of.h> > #include <linux/of_device.h> > #include <linux/of_dma.h> > -#include <linux/of_gpio.h> > #include <linux/mmc/slot-gpio.h> > > #include <asm/dma.h> > -- > 2.20.1 >
On Fri, Feb 8, 2019 at 12:24 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > On Tue, 5 Feb 2019 at 21:07, Linus Walleij <linus.walleij@linaro.org> wrote: > > > > The MXCMMC driver uses slot GPIO helpers and does not make > > any use of <linux/gpio.h> or <linux/of_gpio.h> so drop these > > surplus includes. > > As already pointed out by reviewers, looks like you cut and pasted the > above same changelog for each of the patch in the series. :-) > > Please take a round to update them all for they become correct, then I > can apply them. Not in all cases for sure, but I might have made mistakes. I'll look it over. Yours, Linus Walleij
diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c index 4d17032d15ee..d54612257b06 100644 --- a/drivers/mmc/host/mxcmmc.c +++ b/drivers/mmc/host/mxcmmc.c @@ -31,14 +31,12 @@ #include <linux/delay.h> #include <linux/clk.h> #include <linux/io.h> -#include <linux/gpio.h> #include <linux/regulator/consumer.h> #include <linux/dmaengine.h> #include <linux/types.h> #include <linux/of.h> #include <linux/of_device.h> #include <linux/of_dma.h> -#include <linux/of_gpio.h> #include <linux/mmc/slot-gpio.h> #include <asm/dma.h>
The MXCMMC driver uses slot GPIO helpers and does not make any use of <linux/gpio.h> or <linux/of_gpio.h> so drop these surplus includes. Cc: Jun Qian <hangdianqj@163.com> Cc: Matteo Facchinetti <matteo.facchinetti@sirius-es.it> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/mmc/host/mxcmmc.c | 2 -- 1 file changed, 2 deletions(-) -- 2.20.1