| Message ID | 20190123174839.5321-1-vkoul@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: qcs404: Add Ethernet node | expand |
Hi Niklas, On 24-01-19, 23:06, Niklas Cassel wrote: > On Wed, Jan 23, 2019 at 11:18:39PM +0530, Vinod Koul wrote: > > EVB-4000 has ethernet port with AR8035 Phy, so add phy node > > > > Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org> > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts b/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts > > index 5c02e874be12..ec85647cfed1 100644 > > --- a/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts > > +++ b/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts > > @@ -21,6 +21,17 @@ > > pinctrl-names = "default"; > > pinctrl-0 = <ðernet_defaults>; > > > > + phy-handle = <&phy1>; > > + phy-mode = "rgmii"; > > + mdio { > > + #address-cells = <0x1>; > > + #size-cells = <0x0>; > > + compatible = "snps,dwmac-mdio"; > > + phy1: phy@4 { > > Hello Vinod, > > The AR8035 PHY is compliant with IEEE802.3u clause 22, so please add: > compatible = "ethernet-phy-ieee802.3-c22"; OKay will test and add.. > > Also, please squash this commit with PATCH 2/3. > The previous patch sets status = "ok" without having a PHY defined, > but I also don't see any reason to keep 2/3 and 3/3 as separate patches. Yeah agree, in orignal scheme of things it made sense but not anymore so will do that.. Thanks -- ~Vinod
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi index f3d77e7ee0d2..4696472bdc4e 100644 --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi @@ -346,6 +346,30 @@ status = "okay"; }; + ethernet: ethernet@7a80000 { + compatible = "qcom,qcs404-ethqos"; + reg = <0x07a80000 0x10000>, + <0x07a96000 0x100>; + reg-names = "stmmaceth", "rgmii"; + clock-names = "stmmaceth", "pclk", "ptp_ref", "rgmii"; + clocks = <&gcc GCC_ETH_AXI_CLK>, + <&gcc GCC_ETH_SLAVE_AHB_CLK>, + <&gcc GCC_ETH_PTP_CLK>, + <&gcc GCC_ETH_RGMII_CLK>; + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq", "eth_lpi"; + + snps,txpbl = <8>; + snps,rxpbl = <2>; + snps,aal; + snps,tso; + rx-fifo-depth=<4096>; + tx-fifo-depth=<4096>; + + status = "disabled"; + }; + wifi: wifi@a000000 { compatible = "qcom,wcn3990-wifi"; reg = <0xa000000 0x800000>;