diff mbox

[1/3] ARM: dts: Remove keypad entries from exynos4x12-pinctrl.dtsi

Message ID 1363151289-685-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat March 13, 2013, 5:08 a.m. UTC 
Keypad pins/lines are board specific and should be added to respective
board dts files.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |   56 -----------------------------
 1 files changed, 0 insertions(+), 56 deletions(-)

Comments

Sachin Kamat April 4, 2013, 6:40 a.m. UTC | #1 
Kukjin,
Please check this series.

On 13 March 2013 10:38, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Keypad pins/lines are board specific and should be added to respective
> board dts files.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |   56 -----------------------------
>  1 files changed, 0 insertions(+), 56 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> index 099cec7..704290f 100644
> --- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> @@ -778,62 +778,6 @@
>                         samsung,pin-drv = <3>;
>                 };
>
> -               keypad_col0: keypad-col0 {
> -                       samsung,pins = "gpl2-0";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col1: keypad-col1 {
> -                       samsung,pins = "gpl2-1";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col2: keypad-col2 {
> -                       samsung,pins = "gpl2-2";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col3: keypad-col3 {
> -                       samsung,pins = "gpl2-3";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col4: keypad-col4 {
> -                       samsung,pins = "gpl2-4";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col5: keypad-col5 {
> -                       samsung,pins = "gpl2-5";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col6: keypad-col6 {
> -                       samsung,pins = "gpl2-6";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col7: keypad-col7 {
> -                       samsung,pins = "gpl2-7";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
>                 cam_port_b: cam-port-b {
>                         samsung,pins = "gpm0-0", "gpm0-1", "gpm0-2", "gpm0-3",
>                                         "gpm0-4", "gpm0-5", "gpm0-6", "gpm0-7",
> --
> 1.7.4.1
>
Sachin Kamat April 9, 2013, 2:58 a.m. UTC | #2 
Hi Kukjin,

You seem to have missed out this series from your pull request to arm-soc tree.



On 13 March 2013 10:38, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Keypad pins/lines are board specific and should be added to respective
> board dts files.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |   56 -----------------------------
>  1 files changed, 0 insertions(+), 56 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> index 099cec7..704290f 100644
> --- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> @@ -778,62 +778,6 @@
>                         samsung,pin-drv = <3>;
>                 };
>
> -               keypad_col0: keypad-col0 {
> -                       samsung,pins = "gpl2-0";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col1: keypad-col1 {
> -                       samsung,pins = "gpl2-1";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col2: keypad-col2 {
> -                       samsung,pins = "gpl2-2";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col3: keypad-col3 {
> -                       samsung,pins = "gpl2-3";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col4: keypad-col4 {
> -                       samsung,pins = "gpl2-4";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col5: keypad-col5 {
> -                       samsung,pins = "gpl2-5";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col6: keypad-col6 {
> -                       samsung,pins = "gpl2-6";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
> -               keypad_col7: keypad-col7 {
> -                       samsung,pins = "gpl2-7";
> -                       samsung,pin-function = <3>;
> -                       samsung,pin-pud = <0>;
> -                       samsung,pin-drv = <0>;
> -               };
> -
>                 cam_port_b: cam-port-b {
>                         samsung,pins = "gpm0-0", "gpm0-1", "gpm0-2", "gpm0-3",
>                                         "gpm0-4", "gpm0-5", "gpm0-6", "gpm0-7",
> --
> 1.7.4.1
>
Kukjin Kim April 10, 2013, 10:03 a.m. UTC | #3 
Sachin Kamat wrote:
> 
> Keypad pins/lines are board specific and should be added to respective
> board dts files.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |   56
-------------------------
> ----
>  1 files changed, 0 insertions(+), 56 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> index 099cec7..704290f 100644
> --- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> @@ -778,62 +778,6 @@
>  			samsung,pin-drv = <3>;
>  		};
> 
> -		keypad_col0: keypad-col0 {
> -			samsung,pins = "gpl2-0";
> -			samsung,pin-function = <3>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> -		};
> -
> -		keypad_col1: keypad-col1 {
> -			samsung,pins = "gpl2-1";
> -			samsung,pin-function = <3>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> -		};
> -
> -		keypad_col2: keypad-col2 {
> -			samsung,pins = "gpl2-2";
> -			samsung,pin-function = <3>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> -		};
> -
> -		keypad_col3: keypad-col3 {
> -			samsung,pins = "gpl2-3";
> -			samsung,pin-function = <3>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> -		};
> -
> -		keypad_col4: keypad-col4 {
> -			samsung,pins = "gpl2-4";
> -			samsung,pin-function = <3>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> -		};
> -
> -		keypad_col5: keypad-col5 {
> -			samsung,pins = "gpl2-5";
> -			samsung,pin-function = <3>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> -		};
> -
> -		keypad_col6: keypad-col6 {
> -			samsung,pins = "gpl2-6";
> -			samsung,pin-function = <3>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> -		};
> -
> -		keypad_col7: keypad-col7 {
> -			samsung,pins = "gpl2-7";
> -			samsung,pin-function = <3>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> -		};
> -
>  		cam_port_b: cam-port-b {
>  			samsung,pins = "gpm0-0", "gpm0-1", "gpm0-2",
"gpm0-3",
>  					"gpm0-4", "gpm0-5", "gpm0-6",
"gpm0-7",
> --
> 1.7.4.1

Applied, this whole series.

Thanks.

- Kukjin
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
index 099cec7..704290f 100644
--- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
@@ -778,62 +778,6 @@ 
 			samsung,pin-drv = <3>;
 		};
 
-		keypad_col0: keypad-col0 {
-			samsung,pins = "gpl2-0";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
-
-		keypad_col1: keypad-col1 {
-			samsung,pins = "gpl2-1";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
-
-		keypad_col2: keypad-col2 {
-			samsung,pins = "gpl2-2";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
-
-		keypad_col3: keypad-col3 {
-			samsung,pins = "gpl2-3";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
-
-		keypad_col4: keypad-col4 {
-			samsung,pins = "gpl2-4";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
-
-		keypad_col5: keypad-col5 {
-			samsung,pins = "gpl2-5";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
-
-		keypad_col6: keypad-col6 {
-			samsung,pins = "gpl2-6";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
-
-		keypad_col7: keypad-col7 {
-			samsung,pins = "gpl2-7";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
-
 		cam_port_b: cam-port-b {
 			samsung,pins = "gpm0-0", "gpm0-1", "gpm0-2", "gpm0-3",
 					"gpm0-4", "gpm0-5", "gpm0-6", "gpm0-7",