| Message ID | 1362491397-14562-1-git-send-email-gautam.vivek@samsung.com |
|---|---|
| State | Accepted |
| Commit | 48e2218cd1d63fe968648796d81b8dd6f1cc2bf8 |
| Headers | show |
On Tue, Mar 5, 2013 at 5:49 AM, Vivek Gautam <gautam.vivek@samsung.com> wrote: > Compiling for non-dt systems gives folowing warning: > smdk5250.c: In function 'board_eth_init': > smdk5250.c:152:6: warning: unused variable 'node' [-Wunused-variable] > > Declare variable 'node' only for dt enabled systems to remove this > warning. > > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> Acked-by: Simon Glass <sjg@chromium.org> > --- > board/samsung/smdk5250/smdk5250.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c > index 7a5f132..2fa771e 100644 > --- a/board/samsung/smdk5250/smdk5250.c > +++ b/board/samsung/smdk5250/smdk5250.c > @@ -149,9 +149,10 @@ int board_eth_init(bd_t *bis) > u32 smc_bw_conf, smc_bc_conf; > struct fdt_sromc config; > fdt_addr_t base_addr; > - int node; > > #ifdef CONFIG_OF_CONTROL > + int node; > + > node = decode_sromc(gd->fdt_blob, &config); > if (node < 0) { > debug("%s: Could not find sromc configuration\n", __func__); > -- > 1.7.6.5 >
On 05/03/13 22:49, Vivek Gautam wrote: > Compiling for non-dt systems gives folowing warning: > smdk5250.c: In function 'board_eth_init': > smdk5250.c:152:6: warning: unused variable 'node' [-Wunused-variable] > > Declare variable 'node' only for dt enabled systems to remove this > warning. > > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > --- > board/samsung/smdk5250/smdk5250.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c > index 7a5f132..2fa771e 100644 > --- a/board/samsung/smdk5250/smdk5250.c > +++ b/board/samsung/smdk5250/smdk5250.c > @@ -149,9 +149,10 @@ int board_eth_init(bd_t *bis) > u32 smc_bw_conf, smc_bc_conf; > struct fdt_sromc config; > fdt_addr_t base_addr; > - int node; > > #ifdef CONFIG_OF_CONTROL > + int node; > + > node = decode_sromc(gd->fdt_blob, &config); > if (node < 0) { > debug("%s: Could not find sromc configuration\n", __func__); > applied to u-boot-samsung. Thanks, Minkyu Kang.
diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c index 7a5f132..2fa771e 100644 --- a/board/samsung/smdk5250/smdk5250.c +++ b/board/samsung/smdk5250/smdk5250.c @@ -149,9 +149,10 @@ int board_eth_init(bd_t *bis) u32 smc_bw_conf, smc_bc_conf; struct fdt_sromc config; fdt_addr_t base_addr; - int node; #ifdef CONFIG_OF_CONTROL + int node; + node = decode_sromc(gd->fdt_blob, &config); if (node < 0) { debug("%s: Could not find sromc configuration\n", __func__);
Compiling for non-dt systems gives folowing warning: smdk5250.c: In function 'board_eth_init': smdk5250.c:152:6: warning: unused variable 'node' [-Wunused-variable] Declare variable 'node' only for dt enabled systems to remove this warning. Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> --- board/samsung/smdk5250/smdk5250.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)