| Message ID | 20181126200435.23408-4-minyard@acm.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,01/16] i2c: Split smbus into parts | expand |
On 26/11/18 21:04, minyard@acm.org wrote: > From: Corey Minyard <cminyard@mvista.com> > > It can't fail, and now that it returns a uint8_t a 0xff mask > is unnecessary. > > Signed-off-by: Corey Minyard <cminyard@mvista.com> > Suggested-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/arm/stellaris.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c > index 6c69ce79b2..638b649911 100644 > --- a/hw/arm/stellaris.c > +++ b/hw/arm/stellaris.c > @@ -811,7 +811,7 @@ static void stellaris_i2c_write(void *opaque, hwaddr offset, > /* TODO: Handle errors. */ > if (s->msa & 1) { > /* Recv */ > - s->mdr = i2c_recv(s->bus) & 0xff; > + s->mdr = i2c_recv(s->bus); > } else { > /* Send */ > i2c_send(s->bus, s->mdr); > This could be squashed in the previous patch. Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Mon, 26 Nov 2018 at 20:04, <minyard@acm.org> wrote: > > From: Corey Minyard <cminyard@mvista.com> > > It can't fail, and now that it returns a uint8_t a 0xff mask > is unnecessary. > > Signed-off-by: Corey Minyard <cminyard@mvista.com> > Suggested-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/arm/stellaris.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c > index 6c69ce79b2..638b649911 100644 > --- a/hw/arm/stellaris.c > +++ b/hw/arm/stellaris.c > @@ -811,7 +811,7 @@ static void stellaris_i2c_write(void *opaque, hwaddr offset, > /* TODO: Handle errors. */ > if (s->msa & 1) { > /* Recv */ > - s->mdr = i2c_recv(s->bus) & 0xff; > + s->mdr = i2c_recv(s->bus); > } else { > /* Send */ Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index 6c69ce79b2..638b649911 100644 --- a/hw/arm/stellaris.c +++ b/hw/arm/stellaris.c @@ -811,7 +811,7 @@ static void stellaris_i2c_write(void *opaque, hwaddr offset, /* TODO: Handle errors. */ if (s->msa & 1) { /* Recv */ - s->mdr = i2c_recv(s->bus) & 0xff; + s->mdr = i2c_recv(s->bus); } else { /* Send */ i2c_send(s->bus, s->mdr);