| Message ID | 1361177589-23953-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
Acked-by: Jaehoon Chung <jh80.chung@samsung.com> On 02/18/2013 05:53 PM, Sachin Kamat wrote: > Silences the following sparse warning: > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning: > symbol 'dw_mci_exynos_probe' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/mmc/host/dw_mmc-exynos.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > index 72fd0f2..5a09c77 100644 > --- a/drivers/mmc/host/dw_mmc-exynos.c > +++ b/drivers/mmc/host/dw_mmc-exynos.c > @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = { > }; > MODULE_DEVICE_TABLE(of, dw_mci_exynos_match); > > -int dw_mci_exynos_probe(struct platform_device *pdev) > +static int dw_mci_exynos_probe(struct platform_device *pdev) > { > const struct dw_mci_drv_data *drv_data; > const struct of_device_id *match; >
Hi Sachin, You're right. 'dw_mci_exynos_probe' is only used here. Acked-by: Seungwon Jeon <tgih.jun@samsung.com> On Monday, February 18, 2013, Jaehoon Chung wrote: > Acked-by: Jaehoon Chung <jh80.chung@samsung.com> > > On 02/18/2013 05:53 PM, Sachin Kamat wrote: > > Silences the following sparse warning: > > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning: > > symbol 'dw_mci_exynos_probe' was not declared. Should it be static? > > > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > --- > > drivers/mmc/host/dw_mmc-exynos.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > > index 72fd0f2..5a09c77 100644 > > --- a/drivers/mmc/host/dw_mmc-exynos.c > > +++ b/drivers/mmc/host/dw_mmc-exynos.c > > @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = { > > }; > > MODULE_DEVICE_TABLE(of, dw_mci_exynos_match); > > > > -int dw_mci_exynos_probe(struct platform_device *pdev) > > +static int dw_mci_exynos_probe(struct platform_device *pdev) > > { > > const struct dw_mci_drv_data *drv_data; > > const struct of_device_id *match; > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Chris, On 18 February 2013 16:21, Seungwon Jeon <tgih.jun@samsung.com> wrote: > Hi Sachin, > > You're right. > 'dw_mci_exynos_probe' is only used here. > > Acked-by: Seungwon Jeon <tgih.jun@samsung.com> > > On Monday, February 18, 2013, Jaehoon Chung wrote: >> Acked-by: Jaehoon Chung <jh80.chung@samsung.com> >> >> On 02/18/2013 05:53 PM, Sachin Kamat wrote: >> > Silences the following sparse warning: >> > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning: >> > symbol 'dw_mci_exynos_probe' was not declared. Should it be static? >> > >> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Can you please review this series?
Hi, On Mon, Feb 18 2013, Sachin Kamat wrote: > Silences the following sparse warning: > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning: > symbol 'dw_mci_exynos_probe' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/mmc/host/dw_mmc-exynos.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > index 72fd0f2..5a09c77 100644 > --- a/drivers/mmc/host/dw_mmc-exynos.c > +++ b/drivers/mmc/host/dw_mmc-exynos.c > @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = { > }; > MODULE_DEVICE_TABLE(of, dw_mci_exynos_match); > > -int dw_mci_exynos_probe(struct platform_device *pdev) > +static int dw_mci_exynos_probe(struct platform_device *pdev) > { > const struct dw_mci_drv_data *drv_data; > const struct of_device_id *match; Thanks, pushed to mmc-next for 3.10. - Chris.
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index 72fd0f2..5a09c77 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = { }; MODULE_DEVICE_TABLE(of, dw_mci_exynos_match); -int dw_mci_exynos_probe(struct platform_device *pdev) +static int dw_mci_exynos_probe(struct platform_device *pdev) { const struct dw_mci_drv_data *drv_data; const struct of_device_id *match;
Silences the following sparse warning: drivers/mmc/host/dw_mmc-exynos.c:218:5: warning: symbol 'dw_mci_exynos_probe' was not declared. Should it be static? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/mmc/host/dw_mmc-exynos.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)