diff mbox series

[2,2/2] linux-user/sparc/signal.c: Remove unnecessary comment

Message ID 20181018190026.9494-3-laurent@vivier.eu
State Accepted
Commit 6d5bb0b896f9954c98d85c8835a75bb3a041de41
Headers show
Series [2,1/2] linux-user: Suppress address-of-packed-member warnings in __get/put_user_e | expand

Commit Message

Laurent Vivier Oct. 18, 2018, 7 p.m. UTC 
From: Peter Maydell <peter.maydell@linaro.org>


Remove a comment suggesting that we need to call tb_flush()
after writing the SPARC signal frame trampoline insns.
This isn't necessary in QEMU, because (even if the guest
architecture requires explicit icache maintenance) we
ensure that memory writes result in invalidation of
translated code from that memory.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Message-Id: <20181009184017.15675-1-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>

---
 linux-user/sparc/signal.c | 4 ----
 1 file changed, 4 deletions(-)

-- 
2.17.2
diff mbox series

Patch

diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c
index b4c60aa446..e44e99993c 100644
--- a/linux-user/sparc/signal.c
+++ b/linux-user/sparc/signal.c
@@ -258,10 +258,6 @@  void setup_frame(int sig, struct target_sigaction *ka,
         __put_user(val32, &sf->insns[1]);
         if (err)
             goto sigsegv;
-
-        /* Flush instruction space. */
-        // flush_sig_insns(current->mm, (unsigned long) &(sf->insns[0]));
-        // tb_flush(env);
     }
     unlock_user(sf, sf_addr, sizeof(struct target_signal_frame));
     return;