diff mbox series

slimbus: ngd: QCOM_QMI_HELPERS has to be selected

Message ID 20181003175236.20039-1-srinivas.kandagatla@linaro.org
State New
Headers show
Series slimbus: ngd: QCOM_QMI_HELPERS has to be selected | expand

Commit Message

Srinivas Kandagatla Oct. 3, 2018, 5:52 p.m. UTC
From: Niklas Cassel <niklas.cassel@linaro.org>


QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
to select it, not depend upon it.

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

Reviewed-by: Alex Elder <elder@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

---
 drivers/slimbus/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.19.0

Comments

Greg KH Oct. 15, 2018, 6:32 p.m. UTC | #1
On Wed, Oct 03, 2018 at 06:52:36PM +0100, Srinivas Kandagatla wrote:
> From: Niklas Cassel <niklas.cassel@linaro.org>

> 

> QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is

> to select it, not depend upon it.

> 

> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

> Reviewed-by: Alex Elder <elder@linaro.org>

> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> ---

>  drivers/slimbus/Kconfig | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig

> index 9d73ad806698..9cca2c3559f2 100644

> --- a/drivers/slimbus/Kconfig

> +++ b/drivers/slimbus/Kconfig

> @@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL

>  

>  config SLIM_QCOM_NGD_CTRL

>  	tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"

> -	depends on QCOM_QMI_HELPERS

>  	depends on HAS_IOMEM && DMA_ENGINE

> +	select QCOM_QMI_HELPERS

>  	help

>  	  Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device

>  	  Component is programmed using Linux kernel.

> -- 

> 2.19.0

> 


This adds the following build warning when applied:

WARNING: unmet direct dependencies detected for QCOM_QMI_HELPERS
  Depends on [n]: ARCH_QCOM && NET [=y]
  Selected by [m]:
  - SLIM_QCOM_NGD_CTRL [=m] && SLIMBUS [=m] && HAS_IOMEM [=y] && DMA_ENGINE [=y]
diff mbox series

Patch

diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
index 9d73ad806698..9cca2c3559f2 100644
--- a/drivers/slimbus/Kconfig
+++ b/drivers/slimbus/Kconfig
@@ -22,8 +22,8 @@  config SLIM_QCOM_CTRL
 
 config SLIM_QCOM_NGD_CTRL
 	tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
-	depends on QCOM_QMI_HELPERS
 	depends on HAS_IOMEM && DMA_ENGINE
+	select QCOM_QMI_HELPERS
 	help
 	  Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
 	  Component is programmed using Linux kernel.