| Message ID | 1537260354-30082-2-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 74bc0c09b2da005f028510b1ad21140c9d6c9b44 |
| Headers | show |
| Series | [1/4] kbuild: remove VERSION and PATCHLEVEL from $(objtree)/Makefile | expand |
diff --git a/scripts/mkmakefile b/scripts/mkmakefile index e2106444..2435428 100755 --- a/scripts/mkmakefile +++ b/scripts/mkmakefile @@ -8,7 +8,6 @@ # $1 - Kernel src directory # $2 - Output directory -test ! -r $2/Makefile -o -O $2/Makefile || exit 0 # Only overwrite automatically generated Makefiles # (so we do not overwrite kernel Makefile) if test -e $2/Makefile && ! grep -q Automatically $2/Makefile
This line was added by commit fd5f0cd6b0ce ("kbuild: Do not overwrite makefile as anohter user"). Its commit description says the intention was to prevent $(objtree)/Makefile from being owned by root when e.g. running 'make install'. However, as commit 19514fc665ff ("arm, kbuild: make "make install" not depend on vmlinux") stated, installation targets must not modify the source tree in the first place. If they do, we are already screwed up. We must fix the root cause. Installation targets should just copy files verbatim, hence we never expect $(objtree)/Makefile is touched by root. The user ID check in scripts/mkmakefile is unneeded. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- scripts/mkmakefile | 1 - 1 file changed, 1 deletion(-) -- 2.7.4