| Message ID | CAHqM-QgH3d3Fz=P-_Gj_ZJODK1YOxT49G=qhzAnM=g2HAYqoow@mail.gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tee: optee: log message if dynamic shm is enabled | expand |
On Mon, Sep 10, 2018 at 05:57:28PM +0900, Victor Chong wrote: This (empty) patch description seems unusually terse! Surely there should be some clues in the description about why this messages deserves user/dev/admin attention... > Suggested-by: Jerome Forissier <jerome.forissier@linaro.org> > Signed-off-by: Victor Chong <victor.chong@linaro.org> > Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> > --- > drivers/tee/optee/core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c > index e1aafe842d66..cca5c091e55a 100644 > --- a/drivers/tee/optee/core.c > +++ b/drivers/tee/optee/core.c > @@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np) > > optee_enable_shm_cache(optee); > > + if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM) > + pr_info("dynamic shared memory is enabled\n"); > + > pr_info("initialized driver\n"); > return optee; > err: > -- > 2.17.1
On Mon, Sep 10, 2018 at 6:20 PM, Daniel Thompson <daniel.thompson@linaro.org> wrote: > On Mon, Sep 10, 2018 at 05:57:28PM +0900, Victor Chong wrote: > > This (empty) patch description seems unusually terse! Surely there > should be some clues in the description about why this messages > deserves user/dev/admin attention... Ok. Will add description and send out v2. Thanks > > >> Suggested-by: Jerome Forissier <jerome.forissier@linaro.org> >> Signed-off-by: Victor Chong <victor.chong@linaro.org> >> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> >> --- >> drivers/tee/optee/core.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c >> index e1aafe842d66..cca5c091e55a 100644 >> --- a/drivers/tee/optee/core.c >> +++ b/drivers/tee/optee/core.c >> @@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np) >> >> optee_enable_shm_cache(optee); >> >> + if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM) >> + pr_info("dynamic shared memory is enabled\n"); >> + >> pr_info("initialized driver\n"); >> return optee; >> err: >> -- >> 2.17.1
diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index e1aafe842d66..cca5c091e55a 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np) optee_enable_shm_cache(optee); + if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM) + pr_info("dynamic shared memory is enabled\n"); + pr_info("initialized driver\n"); return optee; err: