diff mbox series

media: camss: mark PM functions as __maybe_unused

Message ID 20180817095425.2630974-1-arnd@arndb.de
State Accepted
Commit 44a9ffd4eb99ada6c1496a735a414414fef30696
Headers show
Series media: camss: mark PM functions as __maybe_unused | expand

Commit Message

Arnd Bergmann Aug. 17, 2018, 9:53 a.m. UTC
The empty suspend/resume functions cause a build warning
when they are unused:

drivers/media/platform/qcom/camss/camss.c:1001:12: error: 'camss_runtime_resume' defined but not used [-Werror=unused-function]
drivers/media/platform/qcom/camss/camss.c:996:12: error: 'camss_runtime_suspend' defined but not used [-Werror=unused-function]

Mark them as __maybe_unused so the compiler can silently drop them.

Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/media/platform/qcom/camss/camss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.18.0

Comments

Todor Tomov Aug. 17, 2018, 11:32 a.m. UTC | #1
Thank you Arnd.

On 17.08.2018 12:53, Arnd Bergmann wrote:
> The empty suspend/resume functions cause a build warning

> when they are unused:

> 

> drivers/media/platform/qcom/camss/camss.c:1001:12: error: 'camss_runtime_resume' defined but not used [-Werror=unused-function]

> drivers/media/platform/qcom/camss/camss.c:996:12: error: 'camss_runtime_suspend' defined but not used [-Werror=unused-function]

> 

> Mark them as __maybe_unused so the compiler can silently drop them.

> 

> Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: Todor Tomov <todor.tomov@linaro.org>


> ---

>  drivers/media/platform/qcom/camss/camss.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c

> index dcc0c30ef1b1..9f19d5f5966b 100644

> --- a/drivers/media/platform/qcom/camss/camss.c

> +++ b/drivers/media/platform/qcom/camss/camss.c

> @@ -993,12 +993,12 @@ static const struct of_device_id camss_dt_match[] = {

>  

>  MODULE_DEVICE_TABLE(of, camss_dt_match);

>  

> -static int camss_runtime_suspend(struct device *dev)

> +static int __maybe_unused camss_runtime_suspend(struct device *dev)

>  {

>  	return 0;

>  }

>  

> -static int camss_runtime_resume(struct device *dev)

> +static int __maybe_unused camss_runtime_resume(struct device *dev)

>  {

>  	return 0;

>  }

> 


-- 
Best regards,
Todor Tomov
Geert Uytterhoeven Aug. 23, 2018, 8:14 p.m. UTC | #2
On Fri, Aug 17, 2018 at 11:54 AM Arnd Bergmann <arnd@arndb.de> wrote:
> The empty suspend/resume functions cause a build warning

> when they are unused:

>

> drivers/media/platform/qcom/camss/camss.c:1001:12: error: 'camss_runtime_resume' defined but not used [-Werror=unused-function]

> drivers/media/platform/qcom/camss/camss.c:996:12: error: 'camss_runtime_suspend' defined but not used [-Werror=unused-function]

>

> Mark them as __maybe_unused so the compiler can silently drop them.

>

> Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
diff mbox series

Patch

diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index dcc0c30ef1b1..9f19d5f5966b 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -993,12 +993,12 @@  static const struct of_device_id camss_dt_match[] = {
 
 MODULE_DEVICE_TABLE(of, camss_dt_match);
 
-static int camss_runtime_suspend(struct device *dev)
+static int __maybe_unused camss_runtime_suspend(struct device *dev)
 {
 	return 0;
 }
 
-static int camss_runtime_resume(struct device *dev)
+static int __maybe_unused camss_runtime_resume(struct device *dev)
 {
 	return 0;
 }