| Message ID | 20180817095131.2557798-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | intel_punit_ipc: include linux/io.h | expand |
On Fri, Aug 17, 2018 at 12:51 PM, Arnd Bergmann <arnd@arndb.de> wrote: > After we stop including linux/irq.h implicitly, we don't see linux/io.h > in intel_punit_ipc.c, leading to a build failure: > > drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status': > drivers/platform/x86/intel_punit_ipc.c:55:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration] > > Add back the include that is clearly needed. > Thanks, Randy already sent a patch > Fixes: 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h") > Cc: Nicolai Stange <nstange@suse.de> > Cc: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/platform/x86/intel_punit_ipc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c > index f1afc0ebbc68..2efeab650345 100644 > --- a/drivers/platform/x86/intel_punit_ipc.c > +++ b/drivers/platform/x86/intel_punit_ipc.c > @@ -18,6 +18,7 @@ > #include <linux/bitops.h> > #include <linux/device.h> > #include <linux/interrupt.h> > +#include <linux/io.h> > #include <linux/platform_device.h> > #include <asm/intel_punit_ipc.h> > > -- > 2.18.0 > -- With Best Regards, Andy Shevchenko
diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c index f1afc0ebbc68..2efeab650345 100644 --- a/drivers/platform/x86/intel_punit_ipc.c +++ b/drivers/platform/x86/intel_punit_ipc.c @@ -18,6 +18,7 @@ #include <linux/bitops.h> #include <linux/device.h> #include <linux/interrupt.h> +#include <linux/io.h> #include <linux/platform_device.h> #include <asm/intel_punit_ipc.h>
After we stop including linux/irq.h implicitly, we don't see linux/io.h in intel_punit_ipc.c, leading to a build failure: drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status': drivers/platform/x86/intel_punit_ipc.c:55:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration] Add back the include that is clearly needed. Fixes: 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h") Cc: Nicolai Stange <nstange@suse.de> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/platform/x86/intel_punit_ipc.c | 1 + 1 file changed, 1 insertion(+) -- 2.18.0