diff mbox

[2/6] ARM: dts: Add MFC codec support for Exynos4 DT machines

Message ID 5107D06F.4000002@samsung.com
State New
Headers show

Commit Message

Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics Jan. 29, 2013, 1:36 p.m. UTC 
On 01/29/2013 05:13 AM, Sachin Kamat wrote:
> This patch adds MFC codec support for Exynos4 DT machines.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4.dtsi         |    7 +++++++
>  arch/arm/mach-exynos/mach-exynos4-dt.c |   17 +++++++++++++++++
>  2 files changed, 24 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index e1347fc..1122fb1 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -289,4 +289,11 @@
>  			interrupts = <0 34 0>;
>  		};
>  	};
> +
> +	mfc: codec@13400000 {
> +		compatible = "samsung,mfc-v5";
> +		reg = <0x13400000 0x10000>;
> +		interrupts = <0 94 0>;
> +		samsung,power-domain = <&pd_mfc>;

Please add:
		status = "disabled";

> +	};
>  };
> diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
> index ab1dacc..8ae8da1 100644
> --- a/arch/arm/mach-exynos/mach-exynos4-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
> @@ -12,7 +12,9 @@
>  */
>  
>  #include <linux/of_platform.h>
> +#include <linux/of_fdt.h>
>  #include <linux/serial_core.h>
> +#include <linux/memblock.h>
>  
>  #include <asm/mach/arch.h>
>  #include <asm/hardware/gic.h>
> @@ -20,6 +22,7 @@
>  
>  #include <plat/cpu.h>
>  #include <plat/regs-serial.h>
> +#include <plat/mfc.h>
>  
>  #include "common.h"
>  
> @@ -80,6 +83,7 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = {
>  	OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_MDMA1, "dma-pl330.2", NULL),
>  	OF_DEV_AUXDATA("samsung,exynos4210-tmu", EXYNOS4_PA_TMU,
>  				"exynos-tmu", NULL),
> +	OF_DEV_AUXDATA("samsung,mfc-v5", 0x13400000, "s5p-mfc", NULL),
>  	{},
>  };
>  
> @@ -102,6 +106,18 @@ static char const *exynos4_dt_compat[] __initdata = {
>  	NULL
>  };
>  
> +static void __init exynos4_reserve(void)
> +{
> +#ifdef CONFIG_S5P_DEV_MFC

Where is this symbol supposed to be enabled ?

Don't you need a change like this as a part of this patch ?


--

Thanks,
Sylwester

Comments

Sachin Kamat Jan. 30, 2013, 6 a.m. UTC | #1 
Hi Sylwester,


>> +     mfc: codec@13400000 {
>> +             compatible = "samsung,mfc-v5";
>> +             reg = <0x13400000 0x10000>;
>> +             interrupts = <0 94 0>;
>> +             samsung,power-domain = <&pd_mfc>;
>
> Please add:
>                 status = "disabled";

OK

>
>> +     };
>>  };
>> +static void __init exynos4_reserve(void)
>> +{
>> +#ifdef CONFIG_S5P_DEV_MFC
>
> Where is this symbol supposed to be enabled ?
>
> Don't you need a change like this as a part of this patch ?

Yes. Good catch. Since this symbol was defined under other machines
which were getting enabled, I did not notice this.

>
diff mbox

Patch

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 1d9312a..1ae72d9 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -413,6 +413,7 @@  config MACH_EXYNOS4_DT
        select USE_OF
        select EXYNOS4_SETUP_USB_PHY
        select ARM_DMA_USE_IOMMU if EXYNOS_IOMMU
+       select S5P_DEV_MFC
        help
          Machine support for Samsung Exynos4 machine with device tree enabled.
          Select this if a fdt blob is available for the Exynos4 SoC based board.