| Message ID | 20180724111600.4158975-4-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 51a2ee0a4e62961131879f8f315052c48265829d |
| Headers | show |
| Series | None | expand |
On Tue, Jul 24, 2018 at 01:13:28PM +0200, Arnd Bergmann wrote: > drivers/staging/rtl8188eu/include/odm.h uses an incorrect encoding > for the '...' character in two comments, which makes it one of the > few non-UTF-8 source files. > > This removes the odd characters and uses the same ASCII representation > that we have in the regular rtlwifi driver. The second instance > of drivers/staging/rtl8723bs/hal/odm.h is garbled in a different way, > so I change it to be the same as well even though it is already > plain ASCII. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- git does not like this patch: error: cannot convert from Binary to UTF-8 fatal: could not parse patch Let me see if I can force it by hand...
On Tue, Jul 24, 2018 at 01:53:17PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jul 24, 2018 at 01:13:28PM +0200, Arnd Bergmann wrote: > > drivers/staging/rtl8188eu/include/odm.h uses an incorrect encoding > > for the '...' character in two comments, which makes it one of the > > few non-UTF-8 source files. > > > > This removes the odd characters and uses the same ASCII representation > > that we have in the regular rtlwifi driver. The second instance > > of drivers/staging/rtl8723bs/hal/odm.h is garbled in a different way, > > so I change it to be the same as well even though it is already > > plain ASCII. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > > git does not like this patch: > error: cannot convert from Binary to UTF-8 > fatal: could not parse patch > Let me see if I can force it by hand... > Had to remove the "Binary" marking on the email and then it worked. Odd... greg k-h
diff --git a/drivers/staging/rtl8188eu/include/odm.h b/drivers/staging/rtl8188eu/include/odm.h index 79affc617f35..947481de9cb1 100644 --- a/drivers/staging/rtl8188eu/include/odm.h +++ b/drivers/staging/rtl8188eu/include/odm.h @@ -708,7 +708,7 @@ struct odm_dm_struct { /* HOOK BEFORE REG INIT----------- */ /* ODM Platform info AP/ADSL/CE/MP = 1/2/3/4 */ u8 SupportPlatform; - /* ODM Support Ability DIG/RATR/TX_PWR_TRACK/ ¡K¡K = 1/2/3/¡K */ + /* ODM Support Ability DIG/RATR/TX_PWR_TRACK/... = 1/2/3/... */ u32 SupportAbility; /* ODM PCIE/USB/SDIO/GSPI = 0/1/2/3 */ u8 SupportInterface; diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h index a4153a660d32..23ab160ac2c8 100644 --- a/drivers/staging/rtl8723bs/hal/odm.h +++ b/drivers/staging/rtl8723bs/hal/odm.h @@ -913,7 +913,7 @@ typedef struct DM_Out_Source_Dynamic_Mechanism_Structure { /* HOOK BEFORE REG INIT----------- */ /* ODM Platform info AP/ADSL/CE/MP = 1/2/3/4 */ u8 SupportPlatform; - /* ODM Support Ability DIG/RATR/TX_PWR_TRACK/ ?K?K = 1/2/3/?K */ + /* ODM Support Ability DIG/RATR/TX_PWR_TRACK/... = 1/2/3/... */ u32 SupportAbility; /* ODM PCIE/USB/SDIO = 1/2/3 */ u8 SupportInterface;
drivers/staging/rtl8188eu/include/odm.h uses an incorrect encoding for the '...' character in two comments, which makes it one of the few non-UTF-8 source files. This removes the odd characters and uses the same ASCII representation that we have in the regular rtlwifi driver. The second instance of drivers/staging/rtl8723bs/hal/odm.h is garbled in a different way, so I change it to be the same as well even though it is already plain ASCII. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/rtl8188eu/include/odm.h | 2 +- drivers/staging/rtl8723bs/hal/odm.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.18.0