[8/9] efi/cper: Use consistent types for UUIDs

Message ID	20180720014726.24031-9-ard.biesheuvel@linaro.org
State	New
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; From: Ard Biesheuvel <ard.biesheuvel@linaro.org> To: linux-efi@vger.kernel.org, Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>, linux-kernel@vger.kernel.org, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Hans de Goede <hdegoede@redhat.com>, Lukas Wunner <lukas@wunner.de> Subject: [PATCH 8/9] efi/cper: Use consistent types for UUIDs Date: Fri, 20 Jul 2018 10:47:25 +0900 Message-Id: <20180720014726.24031-9-ard.biesheuvel@linaro.org> In-Reply-To: <20180720014726.24031-1-ard.biesheuvel@linaro.org> References: <20180720014726.24031-1-ard.biesheuvel@linaro.org> Sender: linux-efi-owner@vger.kernel.org Precedence: bulk
Series	[1/9] efi/x86: prevent reentrant firmware calls in mixed mode \| expand [1/9] efi/x86: prevent reentrant firmware calls in mixed mode [3/9] efi/x86: align efi_uga_draw_protocol typedef names to convention [4/9] efi/x86: merge 32-bit and 64-bit UGA draw protocol setup routines [8/9] efi/cper: Use consistent types for UUIDs

Message ID

20180720014726.24031-9-ard.biesheuvel@linaro.org

State

New

Headers

Received-SPF: pass (google.com: best guess record for domain of
	linux-efi-owner@vger.kernel.org designates 209.132.180.67 as
	permitted sender) client-ip=209.132.180.67; 
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-efi@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>, linux-kernel@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Hans de Goede <hdegoede@redhat.com>, Lukas Wunner <lukas@wunner.de>
Subject: [PATCH 8/9] efi/cper: Use consistent types for UUIDs
Date: Fri, 20 Jul 2018 10:47:25 +0900
Message-Id: <20180720014726.24031-9-ard.biesheuvel@linaro.org>
In-Reply-To: <20180720014726.24031-1-ard.biesheuvel@linaro.org>
References: <20180720014726.24031-1-ard.biesheuvel@linaro.org>
Sender: linux-efi-owner@vger.kernel.org
Precedence: bulk

Series

[1/9] efi/x86: prevent reentrant firmware calls in mixed mode | expand

Commit Message

Ard Biesheuvel July 20, 2018, 1:47 a.m. UTC

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


The commit

  2f74f09bce4f ("efi: parse ARM processor error")

brought inconsistency in UUID types which are used across the CPER.

Fix this by moving to use guid_t API everywhere.

Cc: Tyler Baicar <tbaicar@codeaurora.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 drivers/firmware/efi/cper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
index b73fc4cab083..a7902fccdcfa 100644
--- a/drivers/firmware/efi/cper.c
+++ b/drivers/firmware/efi/cper.c
@@ -472,7 +472,7 @@  cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdata
 		else
 			goto err_section_too_small;
 #if defined(CONFIG_ARM64) || defined(CONFIG_ARM)
-	} else if (!uuid_le_cmp(*sec_type, CPER_SEC_PROC_ARM)) {
+	} else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) {
 		struct cper_sec_proc_arm *arm_err = acpi_hest_get_payload(gdata);
 
 		printk("%ssection_type: ARM processor error\n", newpfx);

[8/9] efi/cper: Use consistent types for UUIDs

Commit Message

Patch