| Message ID | 20180716153005.16552-1-ross.burton@intel.com |
|---|---|
| State | Accepted |
| Commit | 964ea8bfc455f6017dc834104d96b8f5aa40a5bc |
| Headers | show |
| Series | atk: add explicit gettext-native dependency | expand |
On Mon, 2018-07-16 at 16:30 +0100, Ross Burton wrote: > In native builds we attempt to turn off i18n but this doesn't work in > Meson > yet[1] but as the gettext class reduces dependencies in native builds > we need to > add gettext-native to DEPENDS explicitly. > > [1] https://github.com/mesonbuild/meson/issues/821 > > Signed-off-by: Ross Burton <ross.burton@intel.com> > --- > meta/recipes-support/atk/atk_2.28.1.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-support/atk/atk_2.28.1.bb b/meta/recipes- > support/atk/atk_2.28.1.bb > index a051247d8ff..d64df37f5de 100644 > --- a/meta/recipes-support/atk/atk_2.28.1.bb > +++ b/meta/recipes-support/atk/atk_2.28.1.bb > @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd00 > 2f49e7bb854063f7e7 \ > file://atk/atkutil.c;endline=18;md5=6fd31cd2fdc9 > b30f619ca8d819bc12d3 \ > file://atk/atk.h;endline=18;md5=fcd7710187e0eae4 > 85e356c30d1b0c3b" > > -DEPENDS = "glib-2.0" > +DEPENDS = "gettext-native glib-2.0" > > GNOMEBASEBUILDCLASS = "meson" > inherit gnomebase gtk-doc gettext upstream-version-is-even gobject- > introspection Can you at least comment this in the hope we can eventually drop this again please? gettext-native is a huge pain dependency wise and slows down builds significantly. Is there a way we could tweak meson to avoid this? Cheers, Richard -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
There's a bug upstream but non-trivial to resolve. Ross On 16 July 2018 at 17:17, <richard.purdie@linuxfoundation.org> wrote: > On Mon, 2018-07-16 at 16:30 +0100, Ross Burton wrote: >> In native builds we attempt to turn off i18n but this doesn't work in >> Meson >> yet[1] but as the gettext class reduces dependencies in native builds >> we need to >> add gettext-native to DEPENDS explicitly. >> >> [1] https://github.com/mesonbuild/meson/issues/821 >> >> Signed-off-by: Ross Burton <ross.burton@intel.com> >> --- >> meta/recipes-support/atk/atk_2.28.1.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-support/atk/atk_2.28.1.bb b/meta/recipes- >> support/atk/atk_2.28.1.bb >> index a051247d8ff..d64df37f5de 100644 >> --- a/meta/recipes-support/atk/atk_2.28.1.bb >> +++ b/meta/recipes-support/atk/atk_2.28.1.bb >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd00 >> 2f49e7bb854063f7e7 \ >> file://atk/atkutil.c;endline=18;md5=6fd31cd2fdc9 >> b30f619ca8d819bc12d3 \ >> file://atk/atk.h;endline=18;md5=fcd7710187e0eae4 >> 85e356c30d1b0c3b" >> >> -DEPENDS = "glib-2.0" >> +DEPENDS = "gettext-native glib-2.0" >> >> GNOMEBASEBUILDCLASS = "meson" >> inherit gnomebase gtk-doc gettext upstream-version-is-even gobject- >> introspection > > Can you at least comment this in the hope we can eventually drop this > again please? > > gettext-native is a huge pain dependency wise and slows down builds > significantly. Is there a way we could tweak meson to avoid this? > > Cheers, > > Richard > -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Mon, Jul 16, 2018 at 8:30 AM, Ross Burton <ross.burton@intel.com> wrote: > In native builds we attempt to turn off i18n but this doesn't work in Meson > yet[1] but as the gettext class reduces dependencies in native builds we need to > add gettext-native to DEPENDS explicitly. > > [1] https://github.com/mesonbuild/meson/issues/821 > > Signed-off-by: Ross Burton <ross.burton@intel.com> This fixes the build issue for me. Tested-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > meta/recipes-support/atk/atk_2.28.1.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-support/atk/atk_2.28.1.bb b/meta/recipes-support/atk/atk_2.28.1.bb > index a051247d8ff..d64df37f5de 100644 > --- a/meta/recipes-support/atk/atk_2.28.1.bb > +++ b/meta/recipes-support/atk/atk_2.28.1.bb > @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \ > file://atk/atkutil.c;endline=18;md5=6fd31cd2fdc9b30f619ca8d819bc12d3 \ > file://atk/atk.h;endline=18;md5=fcd7710187e0eae485e356c30d1b0c3b" > > -DEPENDS = "glib-2.0" > +DEPENDS = "gettext-native glib-2.0" > > GNOMEBASEBUILDCLASS = "meson" > inherit gnomebase gtk-doc gettext upstream-version-is-even gobject-introspection > -- > 2.11.0 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/recipes-support/atk/atk_2.28.1.bb b/meta/recipes-support/atk/atk_2.28.1.bb index a051247d8ff..d64df37f5de 100644 --- a/meta/recipes-support/atk/atk_2.28.1.bb +++ b/meta/recipes-support/atk/atk_2.28.1.bb @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \ file://atk/atkutil.c;endline=18;md5=6fd31cd2fdc9b30f619ca8d819bc12d3 \ file://atk/atk.h;endline=18;md5=fcd7710187e0eae485e356c30d1b0c3b" -DEPENDS = "glib-2.0" +DEPENDS = "gettext-native glib-2.0" GNOMEBASEBUILDCLASS = "meson" inherit gnomebase gtk-doc gettext upstream-version-is-even gobject-introspection
In native builds we attempt to turn off i18n but this doesn't work in Meson yet[1] but as the gettext class reduces dependencies in native builds we need to add gettext-native to DEPENDS explicitly. [1] https://github.com/mesonbuild/meson/issues/821 Signed-off-by: Ross Burton <ross.burton@intel.com> --- meta/recipes-support/atk/atk_2.28.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core