| Message ID | 1357713829-30273-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Rejected |
| Headers | show |
On Wed, Jan 09, 2013 at 12:13:49PM +0530, Sachin Kamat wrote: > Since devm_input_allocate_device() is used, explicit unregistering > of device is not required as it is handled by devres infrastructure. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/input/keyboard/samsung-keypad.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c > index 22e357b..fab8972 100644 > --- a/drivers/input/keyboard/samsung-keypad.c > +++ b/drivers/input/keyboard/samsung-keypad.c > @@ -501,8 +501,6 @@ static int samsung_keypad_remove(struct platform_device *pdev) > device_init_wakeup(&pdev->dev, 0); > platform_set_drvdata(pdev, NULL); > > - input_unregister_device(keypad->input_dev); > - > clk_unprepare(keypad->clk); > No, don't you see clk_unprepare() call? The device must be unregistered before calling clk_unprepare() to keep proper order of operations. Thanks.
On 9 January 2013 14:51, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Wed, Jan 09, 2013 at 12:13:49PM +0530, Sachin Kamat wrote: >> Since devm_input_allocate_device() is used, explicit unregistering >> of device is not required as it is handled by devres infrastructure. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> drivers/input/keyboard/samsung-keypad.c | 2 -- >> 1 files changed, 0 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c >> index 22e357b..fab8972 100644 >> --- a/drivers/input/keyboard/samsung-keypad.c >> +++ b/drivers/input/keyboard/samsung-keypad.c >> @@ -501,8 +501,6 @@ static int samsung_keypad_remove(struct platform_device *pdev) >> device_init_wakeup(&pdev->dev, 0); >> platform_set_drvdata(pdev, NULL); >> >> - input_unregister_device(keypad->input_dev); >> - >> clk_unprepare(keypad->clk); >> > > No, don't you see clk_unprepare() call? The device must be unregistered > before calling clk_unprepare() to keep proper order of operations. Sorry, my bad. I overlooked it. Thanks for noticing. > > Thanks. > > -- > Dmitry
diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c index 22e357b..fab8972 100644 --- a/drivers/input/keyboard/samsung-keypad.c +++ b/drivers/input/keyboard/samsung-keypad.c @@ -501,8 +501,6 @@ static int samsung_keypad_remove(struct platform_device *pdev) device_init_wakeup(&pdev->dev, 0); platform_set_drvdata(pdev, NULL); - input_unregister_device(keypad->input_dev); - clk_unprepare(keypad->clk); return 0;
Since devm_input_allocate_device() is used, explicit unregistering of device is not required as it is handled by devres infrastructure. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/input/keyboard/samsung-keypad.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)