diff mbox series

tee: replace getnstimeofday64() with ktime_get_real_ts64()

Message ID 20180618142511.3598193-1-arnd@arndb.de
State Accepted
Commit cf89fe88a676d9482313b6b674e9edce34591400
Headers show
Series tee: replace getnstimeofday64() with ktime_get_real_ts64() | expand

Commit Message

Arnd Bergmann June 18, 2018, 2:24 p.m. UTC
The two do the same thing, but we want to have a consistent
naming in the kernel.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/tee/optee/rpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.9.0

Comments

Jens Wiklander June 19, 2018, 1:37 p.m. UTC | #1
On Mon, Jun 18, 2018 at 04:24:56PM +0200, Arnd Bergmann wrote:
> The two do the same thing, but we want to have a consistent

> naming in the kernel.

> 

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  drivers/tee/optee/rpc.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c

> index 41aea12e2bcc..b45c73dd37a5 100644

> --- a/drivers/tee/optee/rpc.c

> +++ b/drivers/tee/optee/rpc.c

> @@ -48,7 +48,7 @@ static void handle_rpc_func_cmd_get_time(struct optee_msg_arg *arg)

>  			OPTEE_MSG_ATTR_TYPE_VALUE_OUTPUT)

>  		goto bad;

>  

> -	getnstimeofday64(&ts);

> +	ktime_get_real_ts64(&ts);

>  	arg->params[0].u.value.a = ts.tv_sec;

>  	arg->params[0].u.value.b = ts.tv_nsec;

>  

> -- 

> 2.9.0

> 


Looks good.

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>


Thanks,
Jens
Arnd Bergmann June 19, 2018, 2:05 p.m. UTC | #2
On Tue, Jun 19, 2018 at 3:37 PM, Jens Wiklander
<jens.wiklander@linaro.org> wrote:
> On Mon, Jun 18, 2018 at 04:24:56PM +0200, Arnd Bergmann wrote:

>> The two do the same thing, but we want to have a consistent

>> naming in the kernel.

>>

>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>> ---

>>  drivers/tee/optee/rpc.c | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c

>> index 41aea12e2bcc..b45c73dd37a5 100644

>> --- a/drivers/tee/optee/rpc.c

>> +++ b/drivers/tee/optee/rpc.c

>> @@ -48,7 +48,7 @@ static void handle_rpc_func_cmd_get_time(struct optee_msg_arg *arg)

>>                       OPTEE_MSG_ATTR_TYPE_VALUE_OUTPUT)

>>               goto bad;

>>

>> -     getnstimeofday64(&ts);

>> +     ktime_get_real_ts64(&ts);

>>       arg->params[0].u.value.a = ts.tv_sec;

>>       arg->params[0].u.value.b = ts.tv_nsec;

>>

>> --

>> 2.9.0

>>

>

> Looks good.

>

> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>


Thanks for the review. Can you pick it up in your tree?

      Arnd
Jens Wiklander June 19, 2018, 2:23 p.m. UTC | #3
On Tue, Jun 19, 2018 at 04:05:38PM +0200, Arnd Bergmann wrote:
> On Tue, Jun 19, 2018 at 3:37 PM, Jens Wiklander

> <jens.wiklander@linaro.org> wrote:

> > On Mon, Jun 18, 2018 at 04:24:56PM +0200, Arnd Bergmann wrote:

> >> The two do the same thing, but we want to have a consistent

> >> naming in the kernel.

> >>

> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> >> ---

> >>  drivers/tee/optee/rpc.c | 2 +-

> >>  1 file changed, 1 insertion(+), 1 deletion(-)

> >>

> >> diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c

> >> index 41aea12e2bcc..b45c73dd37a5 100644

> >> --- a/drivers/tee/optee/rpc.c

> >> +++ b/drivers/tee/optee/rpc.c

> >> @@ -48,7 +48,7 @@ static void handle_rpc_func_cmd_get_time(struct optee_msg_arg *arg)

> >>                       OPTEE_MSG_ATTR_TYPE_VALUE_OUTPUT)

> >>               goto bad;

> >>

> >> -     getnstimeofday64(&ts);

> >> +     ktime_get_real_ts64(&ts);

> >>       arg->params[0].u.value.a = ts.tv_sec;

> >>       arg->params[0].u.value.b = ts.tv_nsec;

> >>

> >> --

> >> 2.9.0

> >>

> >

> > Looks good.

> >

> > Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

> 

> Thanks for the review. Can you pick it up in your tree?


OK, I'll pick it up.

Thanks,
Jens
diff mbox series

Patch

diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c
index 41aea12e2bcc..b45c73dd37a5 100644
--- a/drivers/tee/optee/rpc.c
+++ b/drivers/tee/optee/rpc.c
@@ -48,7 +48,7 @@  static void handle_rpc_func_cmd_get_time(struct optee_msg_arg *arg)
 			OPTEE_MSG_ATTR_TYPE_VALUE_OUTPUT)
 		goto bad;
 
-	getnstimeofday64(&ts);
+	ktime_get_real_ts64(&ts);
 	arg->params[0].u.value.a = ts.tv_sec;
 	arg->params[0].u.value.b = ts.tv_nsec;