| Message ID | 20180605113904.1193671-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 4f416db98beaef2f047709e4693b0a4c64d9bbf8 |
| Headers | show |
| Series | net: hns3: remove unused hclgevf_cfg_func_mta_filter | expand |
From: Arnd Bergmann <arnd@arndb.de> Date: Tue, 5 Jun 2018 13:38:21 +0200 > The last patch apparently added a complete replacement for this > function, but left the old one in place, which now causes a > harmless warning: > > drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c:731:12: 'hclgevf_cfg_func_mta_filter' defined but not used > > I assume it can be removed. > > Fixes: 3a678b5806e6 ("net: hns3: Optimize the VF's process of updating multicast MAC") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied, thanks Arnd.
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c index dd8e8e6718dc..bc8a5760d959 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c @@ -728,17 +728,6 @@ static void hclgevf_reset_tqp_stats(struct hnae3_handle *handle) } } -static int hclgevf_cfg_func_mta_filter(struct hnae3_handle *handle, bool en) -{ - struct hclgevf_dev *hdev = hclgevf_ae_get_hdev(handle); - u8 msg[2] = {0}; - - msg[0] = en; - return hclgevf_send_mbx_msg(hdev, HCLGE_MBX_SET_MULTICAST, - HCLGE_MBX_MAC_VLAN_MC_FUNC_MTA_ENABLE, - msg, 1, false, NULL, 0); -} - static int hclgevf_cfg_func_mta_type(struct hclgevf_dev *hdev) { u8 resp_msg = HCLGEVF_MTA_TYPE_SEL_MAX;
The last patch apparently added a complete replacement for this function, but left the old one in place, which now causes a harmless warning: drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c:731:12: 'hclgevf_cfg_func_mta_filter' defined but not used I assume it can be removed. Fixes: 3a678b5806e6 ("net: hns3: Optimize the VF's process of updating multicast MAC") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 11 ----------- 1 file changed, 11 deletions(-) -- 2.9.0