| Message ID | 20180530213801.731288-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | c1abca96b252a9627f99f39215b84e5de92bf1e3 |
| Headers | show |
| Series | samples: mbochs: add DMA_SHARED_BUFFER dependency | expand |
On Wed, 30 May 2018 23:37:31 +0200 Arnd Bergmann <arnd@arndb.de> wrote: > The new bochs vbe sample fails to link when DMA_SHARED_BUFFER is > disabled: > > ERROR: "dma_buf_export" [samples/vfio-mdev/mbochs.ko] undefined! > ERROR: "dma_buf_fd" [samples/vfio-mdev/mbochs.ko] undefined! > > This uses a 'select' statement to enable that framework, like all > other users do. > > Fixes: 8021194eb3da ("sample: vfio bochs vbe display (host device for bochs-drm)") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > samples/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/samples/Kconfig b/samples/Kconfig > index 3aeaaca77831..bd133efc1a56 100644 > --- a/samples/Kconfig > +++ b/samples/Kconfig > @@ -135,6 +135,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB > config SAMPLE_VFIO_MDEV_MBOCHS > tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only" > depends on VFIO_MDEV_DEVICE && m > + select DMA_SHARED_BUFFER > help > Build a virtual display sample driver for use as a VFIO > mediated device. It supports the region display interface Almost missed this one. Applied to my next branch for v4.18, also updated the referenced commit ID as I've had to rebase to account for a reverted patch in the base. Thanks, Alex
diff --git a/samples/Kconfig b/samples/Kconfig index 3aeaaca77831..bd133efc1a56 100644 --- a/samples/Kconfig +++ b/samples/Kconfig @@ -135,6 +135,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB config SAMPLE_VFIO_MDEV_MBOCHS tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only" depends on VFIO_MDEV_DEVICE && m + select DMA_SHARED_BUFFER help Build a virtual display sample driver for use as a VFIO mediated device. It supports the region display interface
The new bochs vbe sample fails to link when DMA_SHARED_BUFFER is disabled: ERROR: "dma_buf_export" [samples/vfio-mdev/mbochs.ko] undefined! ERROR: "dma_buf_fd" [samples/vfio-mdev/mbochs.ko] undefined! This uses a 'select' statement to enable that framework, like all other users do. Fixes: 8021194eb3da ("sample: vfio bochs vbe display (host device for bochs-drm)") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- samples/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0