diff mbox series

[v2,2/2] clk: meson: axg: let mpll clocks round closest

Message ID 20180515163652.19980-3-jbrunet@baylibre.com
State Accepted
Commit de1ca2d07bdc3fb4a21991ca78b026324636f541
Headers show
Series clk: meson: mpll: add round closest support | expand

Commit Message

Jerome Brunet May 15, 2018, 4:36 p.m. UTC
Let the mpll dividers achieve the closest rate possible, even if
it means rounding the requested rate up.

This is done to improve the accuracy of the rates provided by these
plls to the audio subsystem

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

---
 drivers/clk/meson/axg.c | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.14.3

Comments

Neil Armstrong May 15, 2018, 4:46 p.m. UTC | #1
On 15/05/2018 18:36, Jerome Brunet wrote:
> Let the mpll dividers achieve the closest rate possible, even if

> it means rounding the requested rate up.

> 

> This is done to improve the accuracy of the rates provided by these

> plls to the audio subsystem

> 

> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

> ---

>  drivers/clk/meson/axg.c | 4 ++++

>  1 file changed, 4 insertions(+)

> 

> diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c

> index 5f5d468c1efe..bd4dbc696b88 100644

> --- a/drivers/clk/meson/axg.c

> +++ b/drivers/clk/meson/axg.c

> @@ -461,6 +461,7 @@ static struct clk_regmap axg_mpll0_div = {

>  			.width	 = 1,

>  		},

>  		.lock = &meson_clk_lock,

> +		.flags = CLK_MESON_MPLL_ROUND_CLOSEST,

>  	},

>  	.hw.init = &(struct clk_init_data){

>  		.name = "mpll0_div",

> @@ -507,6 +508,7 @@ static struct clk_regmap axg_mpll1_div = {

>  			.width	 = 1,

>  		},

>  		.lock = &meson_clk_lock,

> +		.flags = CLK_MESON_MPLL_ROUND_CLOSEST,

>  	},

>  	.hw.init = &(struct clk_init_data){

>  		.name = "mpll1_div",

> @@ -553,6 +555,7 @@ static struct clk_regmap axg_mpll2_div = {

>  			.width	 = 1,

>  		},

>  		.lock = &meson_clk_lock,

> +		.flags = CLK_MESON_MPLL_ROUND_CLOSEST,

>  	},

>  	.hw.init = &(struct clk_init_data){

>  		.name = "mpll2_div",

> @@ -599,6 +602,7 @@ static struct clk_regmap axg_mpll3_div = {

>  			.width	 = 1,

>  		},

>  		.lock = &meson_clk_lock,

> +		.flags = CLK_MESON_MPLL_ROUND_CLOSEST,

>  	},

>  	.hw.init = &(struct clk_init_data){

>  		.name = "mpll3_div",

> 


Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Jerome Brunet May 21, 2018, 9:33 a.m. UTC | #2
On Tue, 2018-05-15 at 18:46 +0200, Neil Armstrong wrote:
> On 15/05/2018 18:36, Jerome Brunet wrote:

> > Let the mpll dividers achieve the closest rate possible, even if

> > it means rounding the requested rate up.

> > 

> > This is done to improve the accuracy of the rates provided by these

> > plls to the audio subsystem

> > 

> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

> > ---

> > 

[...]
> 

> Acked-by: Neil Armstrong <narmstrong@baylibre.com>


Applied
diff mbox series

Patch

diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c
index 5f5d468c1efe..bd4dbc696b88 100644
--- a/drivers/clk/meson/axg.c
+++ b/drivers/clk/meson/axg.c
@@ -461,6 +461,7 @@  static struct clk_regmap axg_mpll0_div = {
 			.width	 = 1,
 		},
 		.lock = &meson_clk_lock,
+		.flags = CLK_MESON_MPLL_ROUND_CLOSEST,
 	},
 	.hw.init = &(struct clk_init_data){
 		.name = "mpll0_div",
@@ -507,6 +508,7 @@  static struct clk_regmap axg_mpll1_div = {
 			.width	 = 1,
 		},
 		.lock = &meson_clk_lock,
+		.flags = CLK_MESON_MPLL_ROUND_CLOSEST,
 	},
 	.hw.init = &(struct clk_init_data){
 		.name = "mpll1_div",
@@ -553,6 +555,7 @@  static struct clk_regmap axg_mpll2_div = {
 			.width	 = 1,
 		},
 		.lock = &meson_clk_lock,
+		.flags = CLK_MESON_MPLL_ROUND_CLOSEST,
 	},
 	.hw.init = &(struct clk_init_data){
 		.name = "mpll2_div",
@@ -599,6 +602,7 @@  static struct clk_regmap axg_mpll3_div = {
 			.width	 = 1,
 		},
 		.lock = &meson_clk_lock,
+		.flags = CLK_MESON_MPLL_ROUND_CLOSEST,
 	},
 	.hw.init = &(struct clk_init_data){
 		.name = "mpll3_div",