diff mbox series

[v2,1/5] kbuild: remove unnecessary $(subst $(obj)/, , ...) in modname-multi

Message ID 1521450087-27291-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit 8cd0e46d3f0ce730a5c7d1e9e75765b24b72013a
Headers show
Series [v2,1/5] kbuild: remove unnecessary $(subst $(obj)/, , ...) in modname-multi | expand

Commit Message

Masahiro Yamada March 19, 2018, 9:01 a.m. UTC
In the context ...

    $(obj)/%.s: $(src)/%.c FORCE
            $(call if_changed_dep,cc_s_c)

    $(obj)/%.i: $(src)/%.c FORCE
            $(call if_changed_dep,cpp_i_c)

    $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE
            $(call cmd,force_checksrc)
            $(call if_changed_rule,cc_o_c)

    $(obj)/%.lst: $(src)/%.c FORCE
            $(call if_changed_dep,cc_lst_c)

'$*' returns the stem of the target (the part of '%'), so $(obj)/ has
already been ripped off.

$(subst $(obj)/,,$*.o) is the same as $*.o

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Reviewed-by: Cao jin <caoj.fnst@cn.fujitsu.com>

---

Changes in v2: None

 scripts/Makefile.lib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

Comments

Masahiro Yamada March 20, 2018, 3:33 p.m. UTC | #1
2018-03-19 18:01 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> In the context ...

>

>     $(obj)/%.s: $(src)/%.c FORCE

>             $(call if_changed_dep,cc_s_c)

>

>     $(obj)/%.i: $(src)/%.c FORCE

>             $(call if_changed_dep,cpp_i_c)

>

>     $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE

>             $(call cmd,force_checksrc)

>             $(call if_changed_rule,cc_o_c)

>

>     $(obj)/%.lst: $(src)/%.c FORCE

>             $(call if_changed_dep,cc_lst_c)

>

> '$*' returns the stem of the target (the part of '%'), so $(obj)/ has

> already been ripped off.

>

> $(subst $(obj)/,,$*.o) is the same as $*.o

>

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> Reviewed-by: Cao jin <caoj.fnst@cn.fujitsu.com>

> ---

>

> Changes in v2: None

>



Series, applied to linux-kbuild.


-- 
Best Regards
Masahiro Yamada
diff mbox series

Patch

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 5fd60af..4eedd6e 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -175,7 +175,7 @@  dtc_cpp_flags  = -Wp,-MD,$(depfile).pre.tmp -nostdinc                    \
 
 # Finds the multi-part object the current object will be linked into
 modname-multi = $(sort $(foreach m,$(multi-used),\
-		$(if $(filter $(subst $(obj)/,,$*.o), $($(m:.o=-objs)) $($(m:.o=-y))),$(m:.o=))))
+		$(if $(filter $*.o, $($(m:.o=-objs)) $($(m:.o=-y))),$(m:.o=))))
 
 # Useful for describing the dependency of composite objects
 # Usage: