diff mbox series

[Xen-devel,v5,02/16] xen/arm: setup: use maddr_to_mfn rather than _mfn(paddr_to_pfn(...))

Message ID 20180314182009.14274-3-julien.grall@arm.com
State Superseded
Headers show
Series xen: Convert page_to_mfn and mfn_to_page to use typesafe MFN | expand

Commit Message

Julien Grall March 14, 2018, 6:19 p.m. UTC 
From: Julien Grall <julien.grall@arm.com>

The construction _mfn(paddr_to_pfn(...)) can be simplified by using
maddr_to_mfn.

Signed-off-by: Julien Grall <julien.grall@arm.com>

---
Cc: Stefano Stabellini <sstabellini@kernel.org>

    Changes in v4:
        - Patch added
---
 xen/arch/arm/setup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

George Dunlap March 15, 2018, 4:10 p.m. UTC | #1 
On Wed, Mar 14, 2018 at 6:19 PM,  <julien.grall@arm.com> wrote:
> From: Julien Grall <julien.grall@arm.com>
>
> The construction _mfn(paddr_to_pfn(...)) can be simplified by using
> maddr_to_mfn.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>
diff mbox series

Patch

diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 462736633b..9e1450b7d4 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -268,8 +268,8 @@  void __init discard_initial_modules(void)
         if ( mi->module[i].kind == BOOTMOD_XEN )
             continue;
 
-        if ( !mfn_valid(_mfn(paddr_to_pfn(s))) ||
-             !mfn_valid(_mfn(paddr_to_pfn(e))))
+        if ( !mfn_valid(maddr_to_mfn(s)) ||
+             !mfn_valid(maddr_to_mfn(e)) )
             continue;
 
         dt_unreserved_regions(s, e, init_domheap_pages, 0);