| Message ID | 1517280842-48914-2-git-send-email-heyi.guo@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [edk2,edk2/MdePkg,v1] MdePkg ACPI: Correct processor flags struct of PPTT | expand |
The change looks good to me, Reviewed-by: Star Zeng <star.zeng@intel.com>. But the title seems not so correct. It is about EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR, but not EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR_FLAGS. How about to refine the title? Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Heyi Guo Sent: Tuesday, January 30, 2018 10:54 AM To: leif.lindholm@linaro.org; linaro-uefi@lists.linaro.org; edk2-devel@lists.01.org; graeme.gregory@linaro.org Cc: huangming23@huawei.com; ard.biesheuvel@linaro.org; Gao, Liming <liming.gao@intel.com>; mengfanrong@huawei.com; guoheyi@huawei.com; Heyi Guo <heyi.guo@linaro.org>; zhangjinsong2@huawei.com; Kinney, Michael D <michael.d.kinney@intel.com>; waip23@126.com; wanghuiqiang@huawei.com; huangdaode@hisilicon.com Subject: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags struct of PPTT From: Ming Huang <huangming23@huawei.com> The Type field of EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR should be UINT8 as ACPI version 6.2 specification. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang <huangming23@huawei.com> Signed-off-by: Heyi Guo <heyi.guo@linaro.org> --- MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h index 82d1425..2904d34 100644 --- a/MdePkg/Include/IndustryStandard/Acpi62.h +++ b/MdePkg/Include/IndustryStandard/Acpi62.h @@ -2569,7 +2569,7 @@ typedef struct { /// Processor hierarchy node structure /// typedef struct { - UINT32 Type; + UINT8 Type; UINT8 Length; UINT8 Reserved[2]; EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR_FLAGS Flags; -- 1.9.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
OK, I will refine the title soon. Thanks. On 2018/1/30 11:34, Zeng, Star wrote: > The change looks good to me, Reviewed-by: Star Zeng <star.zeng@intel.com>. > > But the title seems not so correct. > It is about EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR, but not EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR_FLAGS. > How about to refine the title? > > > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Heyi Guo > Sent: Tuesday, January 30, 2018 10:54 AM > To: leif.lindholm@linaro.org; linaro-uefi@lists.linaro.org; edk2-devel@lists.01.org; graeme.gregory@linaro.org > Cc: huangming23@huawei.com; ard.biesheuvel@linaro.org; Gao, Liming <liming.gao@intel.com>; mengfanrong@huawei.com; guoheyi@huawei.com; Heyi Guo <heyi.guo@linaro.org>; zhangjinsong2@huawei.com; Kinney, Michael D <michael.d.kinney@intel.com>; waip23@126.com; wanghuiqiang@huawei.com; huangdaode@hisilicon.com > Subject: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags struct of PPTT > > From: Ming Huang <huangming23@huawei.com> > > The Type field of EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR should be UINT8 as ACPI version 6.2 specification. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang <huangming23@huawei.com> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > --- > MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h > index 82d1425..2904d34 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > @@ -2569,7 +2569,7 @@ typedef struct { > /// Processor hierarchy node structure > /// > typedef struct { > - UINT32 Type; > + UINT8 Type; > UINT8 Length; > UINT8 Reserved[2]; > EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR_FLAGS Flags; > -- > 1.9.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > > . > -- Best Regards, Ming _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h index 82d1425..2904d34 100644 --- a/MdePkg/Include/IndustryStandard/Acpi62.h +++ b/MdePkg/Include/IndustryStandard/Acpi62.h @@ -2569,7 +2569,7 @@ typedef struct { /// Processor hierarchy node structure /// typedef struct { - UINT32 Type; + UINT8 Type; UINT8 Length; UINT8 Reserved[2]; EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR_FLAGS Flags;