| Message ID | 20171129120940.20835-1-julien.grall@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [Xen-devel] Use non-debug build for Xen 4.10 | expand |
>>> On 29.11.17 at 13:09, <julien.grall@linaro.org> wrote: > Modify Config.mk and Kconfig.debug to disable debug by default in > preparation for late RCs and eventual release. > > Signed-off-by: Julien Grall <julien.grall@linaro.org> > > --- > > I would like this to get included before branching. So we can cut the RC > right after branching. I think doing this before branching has proven a bad idea in the past, due to Coverity seeing a sufficiently different set of issues in both modes. I therefore think that turning off debug should actually be part of branching (e.g. be the first commit on the new stable branch). Jan
Hi Jan, On 11/29/2017 01:29 PM, Jan Beulich wrote: >>>> On 29.11.17 at 13:09, <julien.grall@linaro.org> wrote: >> Modify Config.mk and Kconfig.debug to disable debug by default in >> preparation for late RCs and eventual release. >> >> Signed-off-by: Julien Grall <julien.grall@linaro.org> >> >> --- >> >> I would like this to get included before branching. So we can cut the RC >> right after branching. > > I think doing this before branching has proven a bad idea in the > past, due to Coverity seeing a sufficiently different set of issues > in both modes. If Coverity requires debug then the .config used for coverity should have CONFIG_DEBUG=y. So, I find rather strange to have to delay that patch just because of Coverity. > I therefore think that turning off debug should > actually be part of branching (e.g. be the first commit on the new > stable branch). Cheers,
>>> On 29.11.17 at 15:22, <julien.grall@linaro.org> wrote: > On 11/29/2017 01:29 PM, Jan Beulich wrote: >>>>> On 29.11.17 at 13:09, <julien.grall@linaro.org> wrote: >>> Modify Config.mk and Kconfig.debug to disable debug by default in >>> preparation for late RCs and eventual release. >>> >>> Signed-off-by: Julien Grall <julien.grall@linaro.org> >>> >>> --- >>> >>> I would like this to get included before branching. So we can cut the RC >>> right after branching. >> >> I think doing this before branching has proven a bad idea in the >> past, due to Coverity seeing a sufficiently different set of issues >> in both modes. > > If Coverity requires debug then the .config used for coverity should > have CONFIG_DEBUG=y. That would be wrong on stable branches. Coverity works on either build, but produces significantly different results for the two cases. Jan
diff --git a/tools/Rules.mk b/tools/Rules.mk index 61515d3063..6268c14e3a 100644 --- a/tools/Rules.mk +++ b/tools/Rules.mk @@ -31,7 +31,7 @@ CFLAGS_xeninclude = -I$(XEN_INCLUDE) XENSTORE_XENSTORED ?= y # A debug build of tools? -debug ?= y +debug ?= n debug_symbols ?= $(debug) # Set CONFIG_GOLANG=y in .config (or in make) to build golang diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index 8d70f63743..c0f3c017ed 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -3,7 +3,7 @@ menu "Debugging Options" config DEBUG bool "Developer Checks" - default y + default n ---help--- If you say Y here this will enable developer checks such as asserts and extra printks. This option is intended for development purposes
Modify Config.mk and Kconfig.debug to disable debug by default in preparation for late RCs and eventual release. Signed-off-by: Julien Grall <julien.grall@linaro.org> --- I would like this to get included before branching. So we can cut the RC right after branching. --- tools/Rules.mk | 2 +- xen/Kconfig.debug | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)