| Message ID | 20171127114246.2559451-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | b6dc80dbe6cdf4effd5a07bcd37f34cbf25eb07a |
| Headers | show |
| Series | HSI: cmt_speech: use timespec64 instead of timespec | expand |
Hi Arnd, On Mon, Nov 27, 2017 at 12:42:34PM +0100, Arnd Bergmann wrote: > struct timespec should no longer be used because of the y2038 > overflow problem. This code does not suffer from the overflow, > but it's trivial to change it to use timespec64 without changing > the interface, so let's do that. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Thanks, queued. -- Sebastian > drivers/hsi/clients/cmt_speech.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c > index 727f968ac1cb..05b80723d39d 100644 > --- a/drivers/hsi/clients/cmt_speech.c > +++ b/drivers/hsi/clients/cmt_speech.c > @@ -451,11 +451,11 @@ static void cs_hsi_read_on_control_complete(struct hsi_msg *msg) > dev_dbg(&hi->cl->device, "Read on control: %08X\n", cmd); > cs_release_cmd(msg); > if (hi->flags & CS_FEAT_TSTAMP_RX_CTRL) { > - struct timespec tspec; > + struct timespec64 tspec; > struct cs_timestamp *tstamp = > &hi->mmap_cfg->tstamp_rx_ctrl; > > - ktime_get_ts(&tspec); > + ktime_get_ts64(&tspec); > > tstamp->tv_sec = (__u32) tspec.tv_sec; > tstamp->tv_nsec = (__u32) tspec.tv_nsec; > -- > 2.9.0 >
diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c index 727f968ac1cb..05b80723d39d 100644 --- a/drivers/hsi/clients/cmt_speech.c +++ b/drivers/hsi/clients/cmt_speech.c @@ -451,11 +451,11 @@ static void cs_hsi_read_on_control_complete(struct hsi_msg *msg) dev_dbg(&hi->cl->device, "Read on control: %08X\n", cmd); cs_release_cmd(msg); if (hi->flags & CS_FEAT_TSTAMP_RX_CTRL) { - struct timespec tspec; + struct timespec64 tspec; struct cs_timestamp *tstamp = &hi->mmap_cfg->tstamp_rx_ctrl; - ktime_get_ts(&tspec); + ktime_get_ts64(&tspec); tstamp->tv_sec = (__u32) tspec.tv_sec; tstamp->tv_nsec = (__u32) tspec.tv_nsec;
struct timespec should no longer be used because of the y2038 overflow problem. This code does not suffer from the overflow, but it's trivial to change it to use timespec64 without changing the interface, so let's do that. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/hsi/clients/cmt_speech.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0