| Message ID | 1511540697-27387-3-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Fri, Nov 24, 2017 at 5:24 PM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > ARCH_RENESAS is a stronger condition than (ARM || ARM64). > If ARCH_RENESAS is enabled, (ARM || ARM64) is met as well. > > What is worse, the first depends on line prevents COMPILE_TEST from > enabling this driver. It should be removed. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Nov 25, 2017 at 01:24:37AM +0900, Masahiro Yamada wrote: > ARCH_RENESAS is a stronger condition than (ARM || ARM64). > If ARCH_RENESAS is enabled, (ARM || ARM64) is met as well. > > What is worse, the first depends on line prevents COMPILE_TEST from > enabling this driver. It should be removed. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Because COMPILE_TEST now works, buildbot spotted something: https://www.spinics.net/lists/linux-i2c/msg32556.html Likely, we should include linux/io.h in the header?
2017-12-05 0:25 GMT+09:00 Wolfram Sang <wsa@the-dreams.de>: > On Sat, Nov 25, 2017 at 01:24:37AM +0900, Masahiro Yamada wrote: >> ARCH_RENESAS is a stronger condition than (ARM || ARM64). >> If ARCH_RENESAS is enabled, (ARM || ARM64) is met as well. >> >> What is worse, the first depends on line prevents COMPILE_TEST from >> enabling this driver. It should be removed. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > Because COMPILE_TEST now works, buildbot spotted something: > > https://www.spinics.net/lists/linux-i2c/msg32556.html > > Likely, we should include linux/io.h in the header? > Yes. Can you insert a patch before this one? -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 1932188..ac25354 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -595,7 +595,6 @@ config MMC_TMIO config MMC_SDHI tristate "Renesas SDHI SD/SDIO controller support" - depends on SUPERH || ARM || ARM64 depends on SUPERH || ARCH_RENESAS || COMPILE_TEST select MMC_TMIO_CORE help