| Message ID | 20171120062607.124734-1-jc@linux.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: mtk-vcodec: add missing MODULE_LICENSE/DESCRIPTION | expand |
Hi Jesse,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.14 next-20171121]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Jesse-Chan/media-mtk-vcodec-add-missing-MODULE_LICENSE-DESCRIPTION/20171122-124620
base: git://linuxtv.org/media_tree.git master
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa
All errors (new ones prefixed by >>):
>> drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c:55:16: error: expected declaration specifiers or '...' before string constant
MODULE_LICENSE("GPL v2");
^
drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c:56:20: error: expected declaration specifiers or '...' before string constant
MODULE_DESCRIPTION("Mediatek video codec driver");
^
vim +55 drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c
54
> 55 MODULE_LICENSE("GPL v2");
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
On 11/21/17 23:41, kbuild test robot wrote: > Hi Jesse, > > Thank you for the patch! Yet something to improve: missing #include <linux/module.h> Jesse, did you build all of these driver changes? > [auto build test ERROR on linuxtv-media/master] > [also build test ERROR on v4.14 next-20171121] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Jesse-Chan/media-mtk-vcodec-add-missing-MODULE_LICENSE-DESCRIPTION/20171122-124620 > base: git://linuxtv.org/media_tree.git master > config: xtensa-allmodconfig (attached as .config) > compiler: xtensa-linux-gcc (GCC) 4.9.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=xtensa > > All errors (new ones prefixed by >>): > >>> drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c:55:16: error: expected declaration specifiers or '...' before string constant > MODULE_LICENSE("GPL v2"); > ^ > drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c:56:20: error: expected declaration specifiers or '...' before string constant > MODULE_DESCRIPTION("Mediatek video codec driver"); > ^ > > vim +55 drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c > > 54 > > 55 MODULE_LICENSE("GPL v2"); > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > -- ~Randy
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c index 113b2097f061..d8212d759067 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c @@ -51,3 +51,6 @@ int mtk_vcodec_wait_for_done_ctx(struct mtk_vcodec_ctx *ctx, int command, return status; } EXPORT_SYMBOL(mtk_vcodec_wait_for_done_ctx); + +MODULE_LICENSE("GPL v2"); +MODULE_DESCRIPTION("Mediatek video codec driver");
Signed-off-by: Jesse Chan <jc@linux.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.14.1