| Message ID | 20171109222614.5719-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | aa25e446ce76c37bfd75ac06598c316af94e9a26 |
| Headers | show |
| Series | [1/6] dt-bindings: usb: add #phy-cells to usb-nop-xceiv | expand |
* Rob Herring <robh@kernel.org> [171109 14:28]: > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells > property. This is probably because the binding was the precursor to the phy > binding. > > Fixes the following warning in OMAP dts files: > > Warning (phys_property): Missing property '#phy-cells' in node ... > > Signed-off-by: Rob Herring <robh@kernel.org> > Cc: "Benoît Cousson" <bcousson@baylibre.com> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Enric Balletbo i Serra <eballetbo@gmail.com> > Cc: Javier Martinez Canillas <javier@dowhile0.org> > Cc: linux-omap@vger.kernel.org > --- > Please apply to TI tree. Thanks applying into omap-for-v4.15/fixes-dt. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt index 5be01c859b7a..4dc6a8ee3071 100644 --- a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt +++ b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt @@ -2,6 +2,7 @@ USB NOP PHY Required properties: - compatible: should be usb-nop-xceiv +- #phy-cells: Must be 0 Optional properties: - clocks: phandle to the PHY clock. Use as per Documentation/devicetree @@ -33,6 +34,7 @@ Example: reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>; vbus-detect-gpio = <&gpio2 13 GPIO_ACTIVE_HIGH>; vbus-regulator = <&vbus_regulator>; + #phy-cells = <0>; }; hsusb1_phy is a NOP USB PHY device that gets its clock from an oscillator
Consumers of usb-nop-xceiv use the phy binding, but #phy-cells is missing from the binding. This is probably because this binding predates the common phy binding. So add #phy-cells as a required property. This should not break any users as missing should be treated as 0 cells. Signed-off-by: Rob Herring <robh@kernel.org> --- I'll apply to DT tree. Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt | 2 ++ 1 file changed, 2 insertions(+) -- 2.14.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html