| Message ID | 1348567033-5418-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
ping... On 25 September 2012 15:27, Sachin Kamat <sachin.kamat@linaro.org> wrote: > The pointer returned by kzalloc should be tested for NULL > to avoid potential NULL pointer dereference later. Incorrect > pointer was being tested for NULL. Bug introduced by commit fbcf62a3 > (mtd: physmap_of: move parse_obsolete_partitions to become separate > parser). > This patch fixes this bug. > > Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > Cc: Artem Bityutskiy <artem.bityutskiy@intel.com> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/mtd/ofpart.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c > index 64be8f0..d9127e2 100644 > --- a/drivers/mtd/ofpart.c > +++ b/drivers/mtd/ofpart.c > @@ -121,7 +121,7 @@ static int parse_ofoldpart_partitions(struct mtd_info *master, > nr_parts = plen / sizeof(part[0]); > > *pparts = kzalloc(nr_parts * sizeof(*(*pparts)), GFP_KERNEL); > - if (!pparts) > + if (!*pparts) > return -ENOMEM; > > names = of_get_property(dp, "partition-names", &plen); > -- > 1.7.4.1 >
ping On 25 September 2012 15:27, Sachin Kamat <sachin.kamat@linaro.org> wrote: > The pointer returned by kzalloc should be tested for NULL > to avoid potential NULL pointer dereference later. Incorrect > pointer was being tested for NULL. Bug introduced by commit fbcf62a3 > (mtd: physmap_of: move parse_obsolete_partitions to become separate > parser). > This patch fixes this bug. > > Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > Cc: Artem Bityutskiy <artem.bityutskiy@intel.com> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/mtd/ofpart.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c > index 64be8f0..d9127e2 100644 > --- a/drivers/mtd/ofpart.c > +++ b/drivers/mtd/ofpart.c > @@ -121,7 +121,7 @@ static int parse_ofoldpart_partitions(struct mtd_info *master, > nr_parts = plen / sizeof(part[0]); > > *pparts = kzalloc(nr_parts * sizeof(*(*pparts)), GFP_KERNEL); > - if (!pparts) > + if (!*pparts) > return -ENOMEM; > > names = of_get_property(dp, "partition-names", &plen); > -- > 1.7.4.1 >
On Tue, 2012-09-25 at 15:27 +0530, Sachin Kamat wrote: > The pointer returned by kzalloc should be tested for NULL > to avoid potential NULL pointer dereference later. Incorrect > pointer was being tested for NULL. Bug introduced by commit fbcf62a3 > (mtd: physmap_of: move parse_obsolete_partitions to become separate > parser). > This patch fixes this bug. > > Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > Cc: Artem Bityutskiy <artem.bityutskiy@intel.com> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Added Cc: stable@vger.kernel.org [3.2+] and pushed to l2-mtd.git, thanks!
diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c index 64be8f0..d9127e2 100644 --- a/drivers/mtd/ofpart.c +++ b/drivers/mtd/ofpart.c @@ -121,7 +121,7 @@ static int parse_ofoldpart_partitions(struct mtd_info *master, nr_parts = plen / sizeof(part[0]); *pparts = kzalloc(nr_parts * sizeof(*(*pparts)), GFP_KERNEL); - if (!pparts) + if (!*pparts) return -ENOMEM; names = of_get_property(dp, "partition-names", &plen);
The pointer returned by kzalloc should be tested for NULL to avoid potential NULL pointer dereference later. Incorrect pointer was being tested for NULL. Bug introduced by commit fbcf62a3 (mtd: physmap_of: move parse_obsolete_partitions to become separate parser). This patch fixes this bug. Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Cc: Artem Bityutskiy <artem.bityutskiy@intel.com> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/mtd/ofpart.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)