| Message ID | 20171019190948.5754-1-clabbe.montjoie@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk: sunxi: fix build warning | expand |
Hi Stephen, Mike, On Thu, Oct 19, 2017 at 09:09:48PM +0200, Corentin Labbe wrote: > This patch fix the following build warning: > drivers/clk/sunxi/clk-factors.c:279:14: warning: variable 'name' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Can you apply that patch directly? This is the only fix that we're supposed to have for 4.14. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
On 10/20, Maxime Ripard wrote: > Hi Stephen, Mike, > > On Thu, Oct 19, 2017 at 09:09:48PM +0200, Corentin Labbe wrote: > > This patch fix the following build warning: > > drivers/clk/sunxi/clk-factors.c:279:14: warning: variable 'name' set but not used [-Wunused-but-set-variable] > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > Can you apply that patch directly? This is the only fix that we're > supposed to have for 4.14. > Fixes tag? And this is a new warning from the v4.14 merge window? I suppose it only removes code so that's a plus side for merging into fixes. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
On Tue, Oct 24, 2017 at 01:36:28AM -0700, Stephen Boyd wrote: > On 10/20, Maxime Ripard wrote: > > Hi Stephen, Mike, > > > > On Thu, Oct 19, 2017 at 09:09:48PM +0200, Corentin Labbe wrote: > > > This patch fix the following build warning: > > > drivers/clk/sunxi/clk-factors.c:279:14: warning: variable 'name' set but not used [-Wunused-but-set-variable] > > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > > > Can you apply that patch directly? This is the only fix that we're > > supposed to have for 4.14. > > > > Fixes tag? And this is a new warning from the v4.14 merge window? > I suppose it only removes code so that's a plus side for merging > into fixes. > Will do it. Thanks Regards Corentin Labbe
On 10/24, Corentin Labbe wrote: > On Tue, Oct 24, 2017 at 01:36:28AM -0700, Stephen Boyd wrote: > > On 10/20, Maxime Ripard wrote: > > > Hi Stephen, Mike, > > > > > > On Thu, Oct 19, 2017 at 09:09:48PM +0200, Corentin Labbe wrote: > > > > This patch fix the following build warning: > > > > drivers/clk/sunxi/clk-factors.c:279:14: warning: variable 'name' set but not used [-Wunused-but-set-variable] > > > > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > > > > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > > > > > Can you apply that patch directly? This is the only fix that we're > > > supposed to have for 4.14. > > > > > > > Fixes tag? And this is a new warning from the v4.14 merge window? > > I suppose it only removes code so that's a plus side for merging > > into fixes. > > > > Will do it. Does this mean you'll resend? Just telling me commit id would be sufficient. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
diff --git a/drivers/clk/sunxi/clk-factors.c b/drivers/clk/sunxi/clk-factors.c index dfe5e3e32d28..856fef65433b 100644 --- a/drivers/clk/sunxi/clk-factors.c +++ b/drivers/clk/sunxi/clk-factors.c @@ -276,13 +276,11 @@ void sunxi_factors_unregister(struct device_node *node, struct clk *clk) { struct clk_hw *hw = __clk_get_hw(clk); struct clk_factors *factors; - const char *name; if (!hw) return; factors = to_clk_factors(hw); - name = clk_hw_get_name(hw); of_clk_del_provider(node); /* TODO: The composite clock stuff will leak a bit here. */
This patch fix the following build warning: drivers/clk/sunxi/clk-factors.c:279:14: warning: variable 'name' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- drivers/clk/sunxi/clk-factors.c | 2 -- 1 file changed, 2 deletions(-) -- 2.13.6