| Message ID | 20171013092554.531186-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | a4a5d493ebbc680121b584afcaa2c955b6281d0c |
| Headers | show |
| Series | bus: ti-sysc: mark PM functions as __maybe_unused | expand |
* Arnd Bergmann <arnd@arndb.de> [171013 02:27]: > The new bus driver causes a harmless compile-time warning when > CONFIG_PM is disabled: > > drivers/bus/ti-sysc.c:440:12: error: 'sysc_runtime_resume' defined but not used [-Werror=unused-function] > static int sysc_runtime_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~~ > drivers/bus/ti-sysc.c:421:12: error: 'sysc_runtime_suspend' defined but not used [-Werror=unused-function] > static int sysc_runtime_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~ > > This marks the two unused functions as __maybe_unused to shut up > that warning. Thanks applying into omap-for-v4.15/ti-sysc. Regards, Tony
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c index 9b3cb278ce41..8b95d0f0c319 100644 --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -418,7 +418,7 @@ static void sysc_show_registers(struct sysc *ddata) buf); } -static int sysc_runtime_suspend(struct device *dev) +static int __maybe_unused sysc_runtime_suspend(struct device *dev) { struct sysc *ddata; int i; @@ -437,7 +437,7 @@ static int sysc_runtime_suspend(struct device *dev) return 0; } -static int sysc_runtime_resume(struct device *dev) +static int __maybe_unused sysc_runtime_resume(struct device *dev) { struct sysc *ddata; int i, error;
The new bus driver causes a harmless compile-time warning when CONFIG_PM is disabled: drivers/bus/ti-sysc.c:440:12: error: 'sysc_runtime_resume' defined but not used [-Werror=unused-function] static int sysc_runtime_resume(struct device *dev) ^~~~~~~~~~~~~~~~~~~ drivers/bus/ti-sysc.c:421:12: error: 'sysc_runtime_suspend' defined but not used [-Werror=unused-function] static int sysc_runtime_suspend(struct device *dev) ^~~~~~~~~~~~~~~~~~~~ This marks the two unused functions as __maybe_unused to shut up that warning. Fixes: 0eecc636e5a2 ("bus: ti-sysc: Add minimal TI sysc interconnect target driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/bus/ti-sysc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0