| Message ID | 20171012094703.3123730-1-arnd@arndb.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | elf_fdpic: fix unused variable warning | expand |
On Thu, 12 Oct 2017, Arnd Bergmann wrote: > The elf_fdpic code shows a harmless warning when built with MMU > enabled, I ran into this now that the configuration is possible > on ARM randconfig builds: > > fs/binfmt_elf_fdpic.c: In function 'elf_fdpic_dump_segments': > fs/binfmt_elf_fdpic.c:1501:17: error: unused variable 'addr' [-Werror=unused-variable] In fact the warning appears when built *without* MMU. > This adds another #ifdef around the variable declaration to shut > up the warning. > > Fixes: 382e67aec6a7 ("ARM: enable elf_fdpic on systems with an MMU") This annotation is wrong as the warning goes away when CONFIG_MMU=y. > Fixes: e6c1baa9b562 ("convert the rest of binfmt_elf_fdpic to dump_emit()") That is the real culprit. > Signed-off-by: Arnd Bergmann <arnd@arndb.de> With the changelog fixed... Acked-by: Nicolas Pitre <nico@linaro.org> > --- > Who should pick this up? I guess it could go through either the > ARM tree that introduced the warning for ARM and contains a number > of fdpic patches, or it could go through the VFS tree. Given the above I'd say the VFS tree. Nicolas
On Thu, Oct 12, 2017 at 5:21 PM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote: > On Thu, 12 Oct 2017, Arnd Bergmann wrote: > >> The elf_fdpic code shows a harmless warning when built with MMU >> enabled, I ran into this now that the configuration is possible >> on ARM randconfig builds: >> >> fs/binfmt_elf_fdpic.c: In function 'elf_fdpic_dump_segments': >> fs/binfmt_elf_fdpic.c:1501:17: error: unused variable 'addr' [-Werror=unused-variable] > > In fact the warning appears when built *without* MMU. Ah, of course. >> Who should pick this up? I guess it could go through either the >> ARM tree that introduced the warning for ARM and contains a number >> of fdpic patches, or it could go through the VFS tree. > > Given the above I'd say the VFS tree. Ok, I'll create a new version, thanks for taking a look. Arnd
diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index 5429b035e249..429326b6e2e7 100644 --- a/fs/binfmt_elf_fdpic.c +++ b/fs/binfmt_elf_fdpic.c @@ -1498,7 +1498,9 @@ static bool elf_fdpic_dump_segments(struct coredump_params *cprm) struct vm_area_struct *vma; for (vma = current->mm->mmap; vma; vma = vma->vm_next) { +#ifdef CONFIG_MMU unsigned long addr; +#endif if (!maydump(vma, cprm->mm_flags)) continue;
The elf_fdpic code shows a harmless warning when built with MMU enabled, I ran into this now that the configuration is possible on ARM randconfig builds: fs/binfmt_elf_fdpic.c: In function 'elf_fdpic_dump_segments': fs/binfmt_elf_fdpic.c:1501:17: error: unused variable 'addr' [-Werror=unused-variable] This adds another #ifdef around the variable declaration to shut up the warning. Fixes: 382e67aec6a7 ("ARM: enable elf_fdpic on systems with an MMU") Fixes: e6c1baa9b562 ("convert the rest of binfmt_elf_fdpic to dump_emit()") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- Who should pick this up? I guess it could go through either the ARM tree that introduced the warning for ARM and contains a number of fdpic patches, or it could go through the VFS tree. --- fs/binfmt_elf_fdpic.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.0