| Message ID | 20171004183218.4786-2-clabbe.montjoie@gmail.com |
|---|---|
| State | Accepted |
| Commit | 4298555df5e5cb956549de5b01e4c77b1e4bc00a |
| Headers | show |
| Series | [1/2] selinux: fix build warning by removing the unused sid variable | expand |
On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote: > This patch make selinux_task_prlimit() static since it is not used > anywhere else. > This fix the following build warning: > security/selinux/hooks.c:3981:5: warning: no previous prototype for > 'selinux_task_prlimit' [-Wmissing-prototypes] > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> Acked-by: Stephen Smalley <sds@tycho.nsa.gov> > --- > security/selinux/hooks.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 8507a56f85e4..b8a022f4b4a7 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -3977,8 +3977,8 @@ static int selinux_task_getioprio(struct > task_struct *p) > PROCESS__GETSCHED, NULL); > } > > -int selinux_task_prlimit(const struct cred *cred, const struct cred > *tcred, > - unsigned int flags) > +static int selinux_task_prlimit(const struct cred *cred, const > struct cred *tcred, > + unsigned int flags) > { > u32 av = 0; >
On Wed, Oct 4, 2017 at 4:27 PM, Stephen Smalley <sds@tycho.nsa.gov> wrote: > On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote: >> This patch make selinux_task_prlimit() static since it is not used >> anywhere else. >> This fix the following build warning: >> security/selinux/hooks.c:3981:5: warning: no previous prototype for >> 'selinux_task_prlimit' [-Wmissing-prototypes] >> >> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > Acked-by: Stephen Smalley <sds@tycho.nsa.gov> Merged, thanks again. -- paul moore www.paul-moore.com
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 8507a56f85e4..b8a022f4b4a7 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -3977,8 +3977,8 @@ static int selinux_task_getioprio(struct task_struct *p) PROCESS__GETSCHED, NULL); } -int selinux_task_prlimit(const struct cred *cred, const struct cred *tcred, - unsigned int flags) +static int selinux_task_prlimit(const struct cred *cred, const struct cred *tcred, + unsigned int flags) { u32 av = 0;
This patch make selinux_task_prlimit() static since it is not used anywhere else. This fix the following build warning: security/selinux/hooks.c:3981:5: warning: no previous prototype for 'selinux_task_prlimit' [-Wmissing-prototypes] Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- security/selinux/hooks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.13.6