diff mbox series

[edk2,edk2-non-osi,v3,2/7] Hisilicon/D03/Sas: Add SasPlatform

Message ID 1505991597-52989-5-git-send-email-heyi.guo@linaro.org
State Superseded
Headers show
Series None | expand

Commit Message

gary guo Sept. 21, 2017, 10:59 a.m. UTC 
Install protocol to enable sas port which is using and
transmit base address info of sas port to SasDriverDxe.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <huangming23@huawei.com>

---
 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi | Bin 0 -> 3040 bytes
 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf |  24 ++++++++++++++++++++
 2 files changed, 24 insertions(+)

-- 
1.9.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Sept. 21, 2017, 12:49 p.m. UTC | #1 
On Thu, Sep 21, 2017 at 06:59:43PM +0800, Heyi Guo wrote:
> Install protocol to enable sas port which is using and

> transmit base address info of sas port to SasDriverDxe.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ming Huang <huangming23@huawei.com>


On the whole, I'm OK with this - but:

1) This looks like a very simple piece of code, at a low risk to
   reveal anything confidential about Hisilicon IP. Can this be
   made open source?

> ---

>  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi | Bin 0 -> 3040 bytes

>  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf |  24 ++++++++++++++++++++

>  2 files changed, 24 insertions(+)

> 

> diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi

> new file mode 100644

> index 0000000..4255641

> Binary files /dev/null and b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi differ

> diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf

> new file mode 100644

> index 0000000..636be19

> --- /dev/null

> +++ b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf

> @@ -0,0 +1,24 @@

> +#/** @file

> +#

> +#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.

> +#    Copyright (c) 2017, Linaro Limited. All rights reserved.

> +#

> +#    This program and the accompanying materials

> +#    are licensed and made available under the terms and conditions of the BSD License

> +#    which accompanies this distribution. The full text of the license may be found at

> +#    http://opensource.org/licenses/bsd-license.php

> +#

> +#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

> +#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

> +#

> +#**/

> +

> +[Defines]

> +  INF_VERSION                    = 0x00010019

> +  BASE_NAME                      = SasPlatform

> +  FILE_GUID                      = 102D8FC9-20a4-42EB-aC14-1C98BA5b26A4

> +  MODULE_TYPE                    = DXE_DRIVER

> +  VERSION_STRING                 = 1.0

> +

> +[Binaries]


2) [Binaries.AARCH64]

> +  PE32|SasPlatform.efi|*

> -- 

> 1.9.1

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm Sept. 23, 2017, 4:52 p.m. UTC | #2 
On Fri, Sep 22, 2017 at 10:51:37AM +0000, Huangming (Mark) wrote:
> It is not enough time for open the source code this time. There is a
> process for open source and is defferenc from old process.
> SasPlatform and SnpPlatform will open source the next upstream.

Yes, this is fine, given the timescales.
I just wanted to clarify the longer term plan.

Best Regards,

Leif

> 
> -----邮件原件-----
> 发件人: Leif Lindholm [mailto:leif.lindholm@linaro.org] 
> 发送时间: 2017年9月21日 20:50
> 收件人: Heyi Guo <heyi.guo@linaro.org>
> 抄送: linaro-uefi@lists.linaro.org; edk2-devel@lists.01.org; graeme.gregory@linaro.org; ard.biesheuvel@linaro.org; Guoheyi <guoheyi@huawei.com>; wanghuiqiang <wanghuiqiang@huawei.com>; Huangming (Mark) <huangming23@huawei.com>; zhangjinsong (A) <zhangjinsong2@huawei.com>; waip23@126.com
> 主题: Re: [PATCH edk2-non-osi v3 2/7] Hisilicon/D03/Sas: Add SasPlatform
> 
> On Thu, Sep 21, 2017 at 06:59:43PM +0800, Heyi Guo wrote:
> > Install protocol to enable sas port which is using and transmit base 
> > address info of sas port to SasDriverDxe.
> > 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ming Huang <huangming23@huawei.com>
> 
> On the whole, I'm OK with this - but:
> 
> 1) This looks like a very simple piece of code, at a low risk to
>    reveal anything confidential about Hisilicon IP. Can this be
>    made open source?
> 
> > ---
> >  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi | Bin 0 -> 
> > 3040 bytes  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf 
> > |  24 ++++++++++++++++++++
> >  2 files changed, 24 insertions(+)
> > 
> > diff --git 
> > a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi 
> > b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi
> > new file mode 100644
> > index 0000000..4255641
> > Binary files /dev/null and 
> > b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi differ 
> > diff --git 
> > a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf 
> > b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
> > new file mode 100644
> > index 0000000..636be19
> > --- /dev/null
> > +++ b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
> > @@ -0,0 +1,24 @@
> > +#/** @file
> > +#
> > +#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
> > +#    Copyright (c) 2017, Linaro Limited. All rights reserved.
> > +#
> > +#    This program and the accompanying materials
> > +#    are licensed and made available under the terms and conditions of the BSD License
> > +#    which accompanies this distribution. The full text of the license may be found at
> > +#    http://opensource.org/licenses/bsd-license.php
> > +#
> > +#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > +#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > +#
> > +#**/
> > +
> > +[Defines]
> > +  INF_VERSION                    = 0x00010019
> > +  BASE_NAME                      = SasPlatform
> > +  FILE_GUID                      = 102D8FC9-20a4-42EB-aC14-1C98BA5b26A4
> > +  MODULE_TYPE                    = DXE_DRIVER
> > +  VERSION_STRING                 = 1.0
> > +
> > +[Binaries]
> 
> 2) [Binaries.AARCH64]
> 
> > +  PE32|SasPlatform.efi|*
> > --
> > 1.9.1
> >
diff mbox series

Patch

diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi
new file mode 100644
index 0000000..4255641
Binary files /dev/null and b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi differ
diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
new file mode 100644
index 0000000..636be19
--- /dev/null
+++ b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
@@ -0,0 +1,24 @@ 
+#/** @file
+#
+#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
+#    Copyright (c) 2017, Linaro Limited. All rights reserved.
+#
+#    This program and the accompanying materials
+#    are licensed and made available under the terms and conditions of the BSD License
+#    which accompanies this distribution. The full text of the license may be found at
+#    http://opensource.org/licenses/bsd-license.php
+#
+#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+#**/
+
+[Defines]
+  INF_VERSION                    = 0x00010019
+  BASE_NAME                      = SasPlatform
+  FILE_GUID                      = 102D8FC9-20a4-42EB-aC14-1C98BA5b26A4
+  MODULE_TYPE                    = DXE_DRIVER
+  VERSION_STRING                 = 1.0
+
+[Binaries]
+  PE32|SasPlatform.efi|*