| Message ID | 20170915195402.1469159-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | c82a2cb85973707671f1428b05f65243baf85da7 |
| Headers | show |
| Series | clk: pxa: fix building on older compilers | expand |
Arnd Bergmann <arnd@arndb.de> writes: > gcc-4.4 got confused by the inline assembler statement: > > drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch': > drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token > > This removes the extraneous ':' to let all compilers parse the > driver correctly. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> Cheers. -- Robert
On 09/15, Arnd Bergmann wrote: > gcc-4.4 got confused by the inline assembler statement: > > drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch': > drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token > > This removes the extraneous ':' to let all compilers parse the > driver correctly. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
diff --git a/drivers/clk/pxa/clk-pxa.c b/drivers/clk/pxa/clk-pxa.c index 74f64c3c4290..b80dc9d5855c 100644 --- a/drivers/clk/pxa/clk-pxa.c +++ b/drivers/clk/pxa/clk-pxa.c @@ -147,9 +147,7 @@ void pxa2xx_core_turbo_switch(bool on) " b 3f\n" "2: b 1b\n" "3: nop\n" - : "=&r" (unused) - : "r" (clkcfg) - : ); + : "=&r" (unused) : "r" (clkcfg)); local_irq_restore(flags); }
gcc-4.4 got confused by the inline assembler statement: drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch': drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token This removes the extraneous ':' to let all compilers parse the driver correctly. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/clk/pxa/clk-pxa.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.9.0