| Message ID | 1505292990-22957-2-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v5,1/3] irqdomain: export of_phandle_args_to_fwspec | expand |
On Wed, Sep 13, 2017 at 10:56 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > This helper will be useful for irqchip drivers that need to convert > DT binding into IRQ fwspec. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> I'm waiting for the irqchip maintainers to have a look at this. I can carry it in the GPIO tree, but Thomas often prefers to handle me an immutable git branch for infrastructure. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Linus, 2017-09-21 20:34 GMT+09:00 Linus Walleij <linus.walleij@linaro.org>: > On Wed, Sep 13, 2017 at 10:56 AM, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: > >> This helper will be useful for irqchip drivers that need to convert >> DT binding into IRQ fwspec. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > I'm waiting for the irqchip maintainers to have a look at this. > > I can carry it in the GPIO tree, but Thomas often prefers to handle > me an immutable git branch for infrastructure. > > Yours, > Linus Walleij I found a problem in 3/3, so I will fix it in v6. But, I'd like to know if this approach is basically OK or not. Thanks. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 21 Sep 2017, Linus Walleij wrote: > On Wed, Sep 13, 2017 at 10:56 AM, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: > > > This helper will be useful for irqchip drivers that need to convert > > DT binding into IRQ fwspec. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > I'm waiting for the irqchip maintainers to have a look at this. > > I can carry it in the GPIO tree, but Thomas often prefers to handle > me an immutable git branch for infrastructure. I don't think we have colliding stuff coming up, so please carry it in your tree with Acked-by-me. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2017-09-25 19:11 GMT+09:00 Thomas Gleixner <tglx@linutronix.de>: > On Thu, 21 Sep 2017, Linus Walleij wrote: > >> On Wed, Sep 13, 2017 at 10:56 AM, Masahiro Yamada >> <yamada.masahiro@socionext.com> wrote: >> >> > This helper will be useful for irqchip drivers that need to convert >> > DT binding into IRQ fwspec. >> > >> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> >> I'm waiting for the irqchip maintainers to have a look at this. >> >> I can carry it in the GPIO tree, but Thomas often prefers to handle >> me an immutable git branch for infrastructure. > > I don't think we have colliding stuff coming up, so please carry it in your > tree with Acked-by-me. > > Thanks, > > tglx > -- Please hold it back now. I have sent v6, which is self-contained in the GPIO subsystem. I will wait for Linus to check v6. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index 81e4889..440772c 100644 --- a/include/linux/irqdomain.h +++ b/include/linux/irqdomain.h @@ -259,6 +259,8 @@ extern void irq_set_default_host(struct irq_domain *host); extern int irq_domain_alloc_descs(int virq, unsigned int nr_irqs, irq_hw_number_t hwirq, int node, const struct cpumask *affinity); +extern void of_phandle_args_to_fwspec(struct of_phandle_args *irq_data, + struct irq_fwspec *fwspec); static inline struct fwnode_handle *of_node_to_fwnode(struct device_node *node) { diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index e84b705..e34cd63 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -727,8 +727,8 @@ static int irq_domain_translate(struct irq_domain *d, return 0; } -static void of_phandle_args_to_fwspec(struct of_phandle_args *irq_data, - struct irq_fwspec *fwspec) +void of_phandle_args_to_fwspec(struct of_phandle_args *irq_data, + struct irq_fwspec *fwspec) { int i; @@ -738,6 +738,7 @@ static void of_phandle_args_to_fwspec(struct of_phandle_args *irq_data, for (i = 0; i < irq_data->args_count; i++) fwspec->param[i] = irq_data->args[i]; } +EXPORT_SYMBOL_GPL(of_phandle_args_to_fwspec); unsigned int irq_create_fwspec_mapping(struct irq_fwspec *fwspec) {
This helper will be useful for irqchip drivers that need to convert DT binding into IRQ fwspec. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- This patch is necessary for my GPIO driver. Since it is trivial enough, I hope Marc will allow this to go though the GPIO subsystem. If this patch is rejected, I can copy this function into my GPIO driver, but I'd like to avoid code duplication. include/linux/irqdomain.h | 2 ++ kernel/irq/irqdomain.c | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html