| Message ID | 20170911201133.3421636-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND] pcmcia: badge4: avoid unused function warning | expand |
diff --git a/drivers/pcmcia/sa1111_badge4.c b/drivers/pcmcia/sa1111_badge4.c index 2f490930430d..93a5c7423d80 100644 --- a/drivers/pcmcia/sa1111_badge4.c +++ b/drivers/pcmcia/sa1111_badge4.c @@ -144,6 +144,7 @@ int pcmcia_badge4_init(struct sa1111_dev *dev) sa11xx_drv_pcmcia_add_one); } +#ifndef MODULE static int __init pcmv_setup(char *s) { int v[4]; @@ -158,3 +159,4 @@ static int __init pcmv_setup(char *s) } __setup("pcmv=", pcmv_setup); +#endif
The pcmv_setup is only used when the badge4 driver is built-in, but not when it is a loadable module: drivers/pcmcia/sa1111_badge4.c:153:122: error: 'pcmv_setup' defined but not used [-Werror=unused-function] This adds an #ifdef to avoid the definition of the unused function in the modular case. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- Patch was sent on Jan 25 2016, and on July 21, 2017 but got no reply. Andrew, could you pick it up? --- drivers/pcmcia/sa1111_badge4.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.0