| Message ID | 1503178840-21512-4-git-send-email-minyard@acm.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] ipmi: Fix SEL get/set time commands | expand |
On 08/19/2017 11:40 PM, minyard@acm.org wrote: > From: Corey Minyard <cminyard@mvista.com> > > This lets an event be added to the SEL as if a sensor had generated > it. The OpenIPMI driver uses it for storing panic event information. > > Signed-off-by: Corey Minyard <cminyard@mvista.com> > --- > hw/ipmi/ipmi_bmc_sim.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c > index 0f191e8..09b15a8 100644 > --- a/hw/ipmi/ipmi_bmc_sim.c > +++ b/hw/ipmi/ipmi_bmc_sim.c > @@ -38,6 +38,7 @@ > > #define IPMI_NETFN_SENSOR_EVENT 0x04 > > +#define IPMI_CMD_PLATFORM_EVENT_MSG 0x02 > #define IPMI_CMD_SET_SENSOR_EVT_ENABLE 0x28 > #define IPMI_CMD_GET_SENSOR_EVT_ENABLE 0x29 > #define IPMI_CMD_REARM_SENSOR_EVTS 0x2a > @@ -1580,6 +1581,27 @@ static void set_sel_time(IPMIBmcSim *ibs, > ibs->sel.time_offset = now.tv_sec - ((long) val); > } > > +static void platform_event_msg(IPMIBmcSim *ibs, > + uint8_t *cmd, unsigned int cmd_len, > + RspBuffer *rsp) > +{ > + uint8_t event[16]; > + > + event[2] = 2; /* System event record */ > + event[7] = cmd[0]; /* Generator ID */ Like for patch 1, aren't cmd[0] and cmd[1] the 'netfun' and 'cmd' bytes ? Otherwise, I checked the specs. C. > + event[8] = 0; > + event[9] = cmd[1]; /* EvMRev */ > + event[10] = cmd[2]; /* Sensor type */ > + event[11] = cmd[3]; /* Sensor number */ > + event[12] = cmd[4]; /* Event dir / Event type */ > + event[13] = cmd[5]; /* Event data 1 */ > + event[14] = cmd[6]; /* Event data 2 */ > + event[15] = cmd[7]; /* Event data 3 */ > + > + if (sel_add_event(ibs, event)) > + rsp_buffer_set_error(rsp, IPMI_CC_OUT_OF_SPACE); > +} > + > static void set_sensor_evt_enable(IPMIBmcSim *ibs, > uint8_t *cmd, unsigned int cmd_len, > RspBuffer *rsp) > @@ -1756,6 +1778,7 @@ static const IPMINetfn chassis_netfn = { > }; > > static const IPMICmdHandler sensor_event_cmds[] = { > + [IPMI_CMD_PLATFORM_EVENT_MSG] = { platform_event_msg, 8 }, > [IPMI_CMD_SET_SENSOR_EVT_ENABLE] = { set_sensor_evt_enable, 4 }, > [IPMI_CMD_GET_SENSOR_EVT_ENABLE] = { get_sensor_evt_enable, 3 }, > [IPMI_CMD_REARM_SENSOR_EVTS] = { rearm_sensor_evts, 4 }, >
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 0f191e8..09b15a8 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -38,6 +38,7 @@ #define IPMI_NETFN_SENSOR_EVENT 0x04 +#define IPMI_CMD_PLATFORM_EVENT_MSG 0x02 #define IPMI_CMD_SET_SENSOR_EVT_ENABLE 0x28 #define IPMI_CMD_GET_SENSOR_EVT_ENABLE 0x29 #define IPMI_CMD_REARM_SENSOR_EVTS 0x2a @@ -1580,6 +1581,27 @@ static void set_sel_time(IPMIBmcSim *ibs, ibs->sel.time_offset = now.tv_sec - ((long) val); } +static void platform_event_msg(IPMIBmcSim *ibs, + uint8_t *cmd, unsigned int cmd_len, + RspBuffer *rsp) +{ + uint8_t event[16]; + + event[2] = 2; /* System event record */ + event[7] = cmd[0]; /* Generator ID */ + event[8] = 0; + event[9] = cmd[1]; /* EvMRev */ + event[10] = cmd[2]; /* Sensor type */ + event[11] = cmd[3]; /* Sensor number */ + event[12] = cmd[4]; /* Event dir / Event type */ + event[13] = cmd[5]; /* Event data 1 */ + event[14] = cmd[6]; /* Event data 2 */ + event[15] = cmd[7]; /* Event data 3 */ + + if (sel_add_event(ibs, event)) + rsp_buffer_set_error(rsp, IPMI_CC_OUT_OF_SPACE); +} + static void set_sensor_evt_enable(IPMIBmcSim *ibs, uint8_t *cmd, unsigned int cmd_len, RspBuffer *rsp) @@ -1756,6 +1778,7 @@ static const IPMINetfn chassis_netfn = { }; static const IPMICmdHandler sensor_event_cmds[] = { + [IPMI_CMD_PLATFORM_EVENT_MSG] = { platform_event_msg, 8 }, [IPMI_CMD_SET_SENSOR_EVT_ENABLE] = { set_sensor_evt_enable, 4 }, [IPMI_CMD_GET_SENSOR_EVT_ENABLE] = { get_sensor_evt_enable, 3 }, [IPMI_CMD_REARM_SENSOR_EVTS] = { rearm_sensor_evts, 4 },