| Message ID | 20170728132118.261004-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
On Fri, Jul 28, 2017 at 03:21:01PM +0200, Arnd Bergmann wrote: > vboxvideo fails to link without genalloc: > > drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_alloc': > vbox_hgsmi.c:(.text+0x1e): undefined reference to `gen_pool_dma_alloc' > drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_free': > vbox_hgsmi.c:(.text+0xf2): undefined reference to `gen_pool_free' > > This adds a Kconfig select statement, mirroring what all the other > users have. > > Fixes: dd55d44f4084 ("staging: vboxvideo: Add vboxvideo to drivers/staging") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/staging/vboxvideo/Kconfig | 1 + > 1 file changed, 1 insertion(+) Hans sent this same patch 2 days ago, sorry, just applied it now. greg k-h
diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig index a52746f9a670..cfabe3ce4bab 100644 --- a/drivers/staging/vboxvideo/Kconfig +++ b/drivers/staging/vboxvideo/Kconfig @@ -2,6 +2,7 @@ config DRM_VBOXVIDEO tristate "Virtual Box Graphics Card" depends on DRM && X86 && PCI select DRM_KMS_HELPER + select GENERIC_ALLOCATOR help This is a KMS driver for the virtual Graphics Card used in Virtual Box virtual machines.
vboxvideo fails to link without genalloc: drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_alloc': vbox_hgsmi.c:(.text+0x1e): undefined reference to `gen_pool_dma_alloc' drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_free': vbox_hgsmi.c:(.text+0xf2): undefined reference to `gen_pool_free' This adds a Kconfig select statement, mirroring what all the other users have. Fixes: dd55d44f4084 ("staging: vboxvideo: Add vboxvideo to drivers/staging") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/vboxvideo/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0