@@ -571,11 +571,15 @@ sub get_maintainers {
# Find responsible parties
my %exact_pattern_match_hash = ();
+ # By default "THE REST" will be suppressed.
+ my $suppress_the_rest = 1;
foreach my $file (@files) {
my %hash;
my $tvi = find_first_section();
+ # Unless stated otherwise, a file is maintained by "THE REST"
+ my $file_maintained_by_the_rest = 1;
while ($tvi < @typevalue) {
my $start = find_starting_index($tvi);
my $end = find_ending_index($tvi);
@@ -633,6 +637,14 @@ sub get_maintainers {
foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) {
add_categories($line);
+ my $role = get_maintainer_role($line);
+
+ # Check the role, if it is not "THE REST" then the file is not
+ # only maintained by "THE REST".
+ if ( get_maintainer_role($line) ne "supporter:THE REST" ) {
+ $file_maintained_by_the_rest = 0;
+ }
+
if ($sections) {
my $i;
my $start = find_starting_index($line);
@@ -657,6 +669,9 @@ sub get_maintainers {
print("\n");
}
}
+ # If the file is only maintained by "THE REST", then CC all of them on
+ # the patch.
+ $suppress_the_rest = 0 if $file_maintained_by_the_rest;
}
if ($keywords) {
@@ -666,7 +681,8 @@ sub get_maintainers {
}
}
- if ($email_drop_the_rest_supporter_if_supporter_found && $#email_to > 0) {
+ if ($email_drop_the_rest_supporter_if_supporter_found &&
+ $suppress_the_rest && $#email_to > 0) {
my @email_new;
my $do_replace = 0;
foreach my $email (@email_to) {
"THE REST" maintainers should always be CCed for any modification that don't fall under the responsability of a specific component maintainer. However, the script get_maintainers.pl will remove "THE REST" maintainers as soon as one maintainer of a specific component will be present. Fix the script once for all. Signed-off-by: Julien Grall <julien.grall@arm.com> --- I am getting annoyed at requesting contributors to CC "THE REST" because the script didn't properly return the list of maintainers. This should now be fixed. I didn't keep the acked because of the inversion of the logic. Changes in v2: - inverse the logic of the new variable and rename it to suppress_the_rest --- scripts/get_maintainer.pl | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)