| Message ID | 1344615245-25080-1-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | Accepted |
| Commit | 116aae36ae446cd97dd0010ae813194042732ccc |
| Headers | show |
On Fri, Aug 10, 2012 at 05:14:05PM +0100, Peter Maydell wrote: > The comment about the return address from get_page_addr_code() was > well out of date as phys_ram_base has not existed for some time. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > cputlb.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan
diff --git a/cputlb.c b/cputlb.c index 0d1e252..d3e7b25 100644 --- a/cputlb.c +++ b/cputlb.c @@ -312,7 +312,9 @@ void tlb_set_page(CPUArchState *env, target_ulong vaddr, /* NOTE: this function can trigger an exception */ /* NOTE2: the returned address is not exactly the physical address: it - is the offset relative to phys_ram_base */ + * is actually a ram_addr_t (in system mode; the user mode emulation + * version of this function returns a guest virtual address). + */ tb_page_addr_t get_page_addr_code(CPUArchState *env1, target_ulong addr) { int mmu_idx, page_index, pd;
The comment about the return address from get_page_addr_code() was well out of date as phys_ram_base has not existed for some time. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- cputlb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)