diff mbox series

[3/4] PCI: versatile: fix typo

Message ID 20170621215323.3921382-3-arnd@arndb.de
State New
Headers show
Series [1/4] ARM/PCI: iop13xx: address uninitialized variable warning | expand

Commit Message

Arnd Bergmann June 21, 2017, 9:53 p.m. UTC
There is no 'dev' variable in this function:

drivers/pci/host/pci-versatile.c: In function 'versatile_pci_probe':
drivers/pci/host/pci-versatile.c:131:38: error: 'dev' undeclared (first use in this function); did you mean 'pdev'?

This passes the device embedded in the platform_device instead.

Fixes: 433d2671da1b ("PCI: versatile: Convert PCI scan API to pci_scan_root_bus_bridge()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/pci/host/pci-versatile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.9.0

Comments

Bjorn Helgaas June 27, 2017, 10:49 p.m. UTC | #1
On Wed, Jun 21, 2017 at 11:53:01PM +0200, Arnd Bergmann wrote:
> There is no 'dev' variable in this function:

> 

> drivers/pci/host/pci-versatile.c: In function 'versatile_pci_probe':

> drivers/pci/host/pci-versatile.c:131:38: error: 'dev' undeclared (first use in this function); did you mean 'pdev'?

> 

> This passes the device embedded in the platform_device instead.

> 

> Fixes: 433d2671da1b ("PCI: versatile: Convert PCI scan API to pci_scan_root_bus_bridge()")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Folded into Lorenzo's series on pci/enumeration, thanks!

> ---

>  drivers/pci/host/pci-versatile.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/pci/host/pci-versatile.c b/drivers/pci/host/pci-versatile.c

> index 3be25a9dd29a..f572c921cdd4 100644

> --- a/drivers/pci/host/pci-versatile.c

> +++ b/drivers/pci/host/pci-versatile.c

> @@ -128,7 +128,7 @@ static int versatile_pci_probe(struct platform_device *pdev)

>  	struct pci_host_bridge *bridge;

>  	LIST_HEAD(pci_res);

>  

> -	bridge = devm_pci_alloc_host_bridge(dev, 0);

> +	bridge = devm_pci_alloc_host_bridge(&pdev->dev, 0);

>  	if (!bridge)

>  		return -ENOMEM;

>  

> -- 

> 2.9.0

> 

> 

> _______________________________________________

> linux-arm-kernel mailing list

> linux-arm-kernel@lists.infradead.org

> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox series

Patch

diff --git a/drivers/pci/host/pci-versatile.c b/drivers/pci/host/pci-versatile.c
index 3be25a9dd29a..f572c921cdd4 100644
--- a/drivers/pci/host/pci-versatile.c
+++ b/drivers/pci/host/pci-versatile.c
@@ -128,7 +128,7 @@  static int versatile_pci_probe(struct platform_device *pdev)
 	struct pci_host_bridge *bridge;
 	LIST_HEAD(pci_res);
 
-	bridge = devm_pci_alloc_host_bridge(dev, 0);
+	bridge = devm_pci_alloc_host_bridge(&pdev->dev, 0);
 	if (!bridge)
 		return -ENOMEM;