| Message ID | 1343272507-20825-1-git-send-email-kejun.zhou@linaro.org |
|---|---|
| State | New |
| Headers | show |
Kejun, On Thu, Jul 26, 2012 at 8:45 AM, kejun.zhou <kejun.zhou@linaro.org> wrote: > From: "kejun.zhou" <dp583@stebjsxu0119.(none)> Commit message? > Signed-off-by: kejun.zhou <kejun.zhou@linaro.org> In the future, please indicate in the email subject and commit message what project/subsystem this patch is meant for. Since you've cc'ed Rajagopal, I'm guessing this applies to powertop. > --- > Android.mk | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Android.mk b/Android.mk > index c82cd95..fa1c225 100644 > --- a/Android.mk > +++ b/Android.mk > @@ -28,7 +28,9 @@ LOCAL_CPPFLAGS += -DDISABLE_I18N \ > -DNCURSES_NOMACROS \ > -DHAVE_NO_PCI \ > -DDEFAULT_TERM=\"xterm\" \ > - -DTERMINFO_PATH=\"/system/etc/terminfo\" > + -DTERMINFO_PATH=\"/system/etc/terminfo\" \ > + -fno-exceptions \ > + -fno-rtti \ > > LOCAL_C_INCLUDES += external/stlport/stlport/ \ > external/stlport/stlport/stl \ > -- > 1.7.10 >
Hi Rajagopal, This patch is for git://git.linaro.org/tools/powertop-2.0.git BRs, Kejun On 26 July 2012 12:27, Amit Kucheria <amit.kucheria@linaro.org> wrote: > Kejun, > > On Thu, Jul 26, 2012 at 8:45 AM, kejun.zhou <kejun.zhou@linaro.org> wrote: > > From: "kejun.zhou" <dp583@stebjsxu0119.(none)> > > Commit message? > > > Signed-off-by: kejun.zhou <kejun.zhou@linaro.org> > > In the future, please indicate in the email subject and commit message > what project/subsystem this patch is meant for. Since you've cc'ed > Rajagopal, I'm guessing this applies to powertop. > > > --- > > Android.mk | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Android.mk b/Android.mk > > index c82cd95..fa1c225 100644 > > --- a/Android.mk > > +++ b/Android.mk > > @@ -28,7 +28,9 @@ LOCAL_CPPFLAGS += -DDISABLE_I18N \ > > -DNCURSES_NOMACROS \ > > -DHAVE_NO_PCI \ > > -DDEFAULT_TERM=\"xterm\" \ > > - -DTERMINFO_PATH=\"/system/etc/terminfo\" > > + -DTERMINFO_PATH=\"/system/etc/terminfo\" \ > > + -fno-exceptions \ > > + -fno-rtti \ > > > > LOCAL_C_INCLUDES += external/stlport/stlport/ \ > > external/stlport/stlport/stl \ > > -- > > 1.7.10 > > >
On 26 July 2012 08:45, kejun.zhou <kejun.zhou@linaro.org> wrote: > From: "kejun.zhou" <dp583@stebjsxu0119.(none)> > > Signed-off-by: kejun.zhou <kejun.zhou@linaro.org> > --- > Android.mk | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Android.mk b/Android.mk > index c82cd95..fa1c225 100644 > --- a/Android.mk > +++ b/Android.mk > @@ -28,7 +28,9 @@ LOCAL_CPPFLAGS += -DDISABLE_I18N \ > -DNCURSES_NOMACROS \ > -DHAVE_NO_PCI \ > -DDEFAULT_TERM=\"xterm\" \ > - -DTERMINFO_PATH=\"/system/etc/terminfo\" > + -DTERMINFO_PATH=\"/system/etc/terminfo\" \ > + -fno-exceptions \ > + -fno-rtti \ > > I think no-exceptions and no-rtti options are enabled by default in Android toolchain. Compiler throws "exception handling disabled, use -fexceptions to enable" error when powertop is compiled with exceptions. Moreover for Android, powertop exception handling is disabled through DISABLE_TRYCATCH macro which is set in Android.mk. > LOCAL_C_INCLUDES += external/stlport/stlport/ \ > external/stlport/stlport/stl \ > -- > 1.7.10 > >
OK. Please ignore the patch. On 26 July 2012 13:52, Rajagopal Venkat <rajagopal.venkat@linaro.org> wrote: > > > On 26 July 2012 08:45, kejun.zhou <kejun.zhou@linaro.org> wrote: > >> From: "kejun.zhou" <dp583@stebjsxu0119.(none)> >> >> Signed-off-by: kejun.zhou <kejun.zhou@linaro.org> >> --- >> Android.mk | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Android.mk b/Android.mk >> index c82cd95..fa1c225 100644 >> --- a/Android.mk >> +++ b/Android.mk >> @@ -28,7 +28,9 @@ LOCAL_CPPFLAGS += -DDISABLE_I18N \ >> -DNCURSES_NOMACROS \ >> -DHAVE_NO_PCI \ >> -DDEFAULT_TERM=\"xterm\" \ >> - -DTERMINFO_PATH=\"/system/etc/terminfo\" >> + -DTERMINFO_PATH=\"/system/etc/terminfo\" \ >> + -fno-exceptions \ >> + -fno-rtti \ >> >> I think no-exceptions and no-rtti options are enabled by default in > Android toolchain. > Compiler throws "exception handling disabled, use -fexceptions to enable" > error > when powertop is compiled with exceptions. > > Moreover for Android, powertop exception handling is disabled through > DISABLE_TRYCATCH macro which is set in Android.mk. > > >> LOCAL_C_INCLUDES += external/stlport/stlport/ \ >> external/stlport/stlport/stl \ >> -- >> 1.7.10 >> >> >
diff --git a/Android.mk b/Android.mk index c82cd95..fa1c225 100644 --- a/Android.mk +++ b/Android.mk @@ -28,7 +28,9 @@ LOCAL_CPPFLAGS += -DDISABLE_I18N \ -DNCURSES_NOMACROS \ -DHAVE_NO_PCI \ -DDEFAULT_TERM=\"xterm\" \ - -DTERMINFO_PATH=\"/system/etc/terminfo\" + -DTERMINFO_PATH=\"/system/etc/terminfo\" \ + -fno-exceptions \ + -fno-rtti \ LOCAL_C_INCLUDES += external/stlport/stlport/ \ external/stlport/stlport/stl \